From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ecbcS-0001oT-Uq for qemu-devel@nongnu.org; Fri, 19 Jan 2018 13:42:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ecbcP-0001t3-SG for qemu-devel@nongnu.org; Fri, 19 Jan 2018 13:42:29 -0500 Received: from mx1.redhat.com ([209.132.183.28]:36152) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ecbcP-0001sm-Lv for qemu-devel@nongnu.org; Fri, 19 Jan 2018 13:42:25 -0500 Date: Fri, 19 Jan 2018 16:42:16 -0200 From: Eduardo Habkost Message-ID: <20180119184216.GE5292@localhost.localdomain> References: <20180119141105.29095-1-marcandre.lureau@redhat.com> <20180119141105.29095-5-marcandre.lureau@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 4/5] tpm: add CRB device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Berger Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , qemu-devel@nongnu.org, "Michael S. Tsirkin" , Igor Mammedov , Paolo Bonzini , Richard Henderson , Marcel Apfelbaum , Eric Blake , Markus Armbruster On Fri, Jan 19, 2018 at 12:10:03PM -0500, Stefan Berger wrote: > On 01/19/2018 09:11 AM, Marc-Andr=C3=A9 Lureau wrote: > > tpm_crb is a device for TPM 2.0 Command Response Buffer (CRB) > > Interface as defined in TCG PC Client Platform TPM Profile (PTP) > > Specification Family =E2=80=9C2.0=E2=80=9D Level 00 Revision 01.03 v2= 2. > >=20 > > The PTP allows device implementation to switch between TIS and CRB > > model at run time, but given that CRB is a simpler device to > > implement, I chose to implement it as a different device. > >=20 > > The device doesn't implement other locality than 0 for now (my laptop > > TPM doesn't either, so I assume this isn't so bad) > >=20 > > The command/reply memory region is statically allocated after the CRB > > registers address TPM_CRB_ADDR_BASE + sizeof(struct crb_regs) (I > > wonder if the BIOS could or should allocate it instead, or what size > > to use, again this seems to fit well expectations) >=20 > I removed this last sentence now. It's at the right location. >=20 > >=20 > > The PTP doesn't specify a particular bus to put the device. So I adde= d > > it on the system bus directly, so it could hopefully be used easily o= n > > a different platform than x86. Currently, it fails to init on piix, > > because error_on_sysbus_device() check. The check may be changed in a > > near future, see discussion on the qemu-devel ML. >=20 > I think this has to be solved. So I remove these last 2 sentences. I'll= have > to wait until that other patch series from Eduard is merged since it do= esn't > start yet. The series was just merged to master. It's possible to make a machine accept the new device using machine_class_allow_dynamic_sysbus_dev(), now. However, is it really necessary to make it a sysbus device? Having bus-less devices was not possible in the past, but it is possible today. --=20 Eduardo