From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [RFC 24/24] WORKAROUND examples/vhost_scsi: avoid broken EVENT_IDX Date: Fri, 19 Jan 2018 21:31:32 +0200 Message-ID: <20180119213030-mutt-send-email-mst@kernel.org> References: <20180119134444.24927-1-stefanha@redhat.com> <20180119134444.24927-25-stefanha@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org, maxime.coquelin@redhat.com, Yuanhan Liu , wei.w.wang@intel.com, zhiyong.yang@intel.com, jasowang@redhat.com To: Stefan Hajnoczi Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E10F21B298 for ; Fri, 19 Jan 2018 20:31:40 +0100 (CET) Content-Disposition: inline In-Reply-To: <20180119134444.24927-25-stefanha@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 19, 2018 at 01:44:44PM +0000, Stefan Hajnoczi wrote: > The EVENT_IDX code in DPDK is broken. It's missing the > signalled_used_valid flag that handles the corner cases (startup and > wrapping). Disable it for now. > > Signed-off-by: Stefan Hajnoczi FYI signalled_used_valid isn't strictly required, there are ways to handle event idx without that, e.g. like virtio within guest. > --- > examples/vhost_scsi/vhost_scsi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c > index 61001cadb..7106dc6d2 100644 > --- a/examples/vhost_scsi/vhost_scsi.c > +++ b/examples/vhost_scsi/vhost_scsi.c > @@ -22,7 +22,6 @@ > #include "scsi_spec.h" > > #define VIRTIO_SCSI_FEATURES ((1 << VIRTIO_F_NOTIFY_ON_EMPTY) |\ > - (1 << VIRTIO_RING_F_EVENT_IDX) |\ > (1 << VIRTIO_SCSI_F_INOUT) |\ > (1 << VIRTIO_SCSI_F_CHANGE)) > > -- > 2.14.3