From: Ladislav Michl <ladis@linux-mips.org>
To: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 0/2] Fix double mem region release
Date: Sat, 20 Jan 2018 00:36:06 +0100 [thread overview]
Message-ID: <20180119233606.GA18837@lenoch> (raw)
In-Reply-To: <20180119180310.GA31540@lenoch>
On Fri, Jan 19, 2018 at 07:03:10PM +0100, Ladislav Michl wrote:
> Two one-liners for the same issue, second bug occurrence is just
> a copy&pasted mistake from 2011...
>
> Ladislav Michl (2):
> devres: Fix double mem region release in devm_ioremap_resource()
> PCI: Fix double mem region release in devm_pci_remap_cfg_resource()
Hmm, that is really shame :-/ My test setup triggered "Trying to free
nonexistent resource" warning, but dissasembly of lib/devres.o shows
no call to devres_destroy, which seems that WARN_ON in
__devm_release_region() is optimized out. Strange. So far sorry
for the noise, I'll try figure out what broke after weekend.
> drivers/pci/pci.c | 1 -
> lib/devres.c | 1 -
> 2 files changed, 2 deletions(-)
>
> --
> 2.15.1
>
prev parent reply other threads:[~2018-01-19 23:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 18:03 [PATCH 0/2] Fix double mem region release Ladislav Michl
2018-01-19 18:04 ` [PATCH 1/2] devres: Fix double mem region release in devm_ioremap_resource() Ladislav Michl
2018-01-19 18:05 ` [PATCH 2/2] PCI: Fix double mem region release in devm_pci_remap_cfg_resource() Ladislav Michl
2018-01-19 23:36 ` Ladislav Michl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180119233606.GA18837@lenoch \
--to=ladis@linux-mips.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.