From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [4.9] usbip: fix warning in vhci_hcd_probe/lockdep_init_map From: Greg Kroah-Hartman Message-Id: <20180121162711.GA18144@kroah.com> Date: Sun, 21 Jan 2018 17:27:11 +0100 To: Shuah Khan Cc: valentina.manea.m@gmail.com, shuah@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org List-ID: T24gV2VkLCBKYW4gMTcsIDIwMTggYXQgMDM6MDM6NDNQTSAtMDcwMCwgU2h1YWggS2hhbiB3cm90 ZToKPiBjb21taXQgOTE4YjhhYzU1YjZjODA5YjcwYWEwNWMyNzkwODcxMDk1ODRlMzkzZSB1cHN0 cmVhbQo+IAo+IHZoY2lfaGNkIGNhbGxzIHN5c2ZzX2NyZWF0ZV9ncm91cCgpIHdpdGggZHluYW1p Y2FsbHkgYWxsb2NhdGVkIHN5c2ZzCj4gYXR0cmlidXRlcyB0cmlnZ2VyaW5nIHRoZSBsb2NrLWNs YXNzIGtleSBub3QgcGVyc2lzdGVudCB3YXJuaW5nLiBDYWxsCj4gc3lzZnNfYXR0cl9pbml0KCkg Zm9yIGR5bmFtaWNhbGx5IGFsbG9jYXRlZCBzeXNmcyBhdHRyaWJ1dGVzIHRvIGZpeCBpdC4KPiAK PiB2aGNpX2hjZCB2aGNpX2hjZDogVVNCL0lQIFZpcnR1YWwgSG9zdCBDb250cm9sbGVyCj4gdmhj aV9oY2QgdmhjaV9oY2Q6IG5ldyBVU0IgYnVzIHJlZ2lzdGVyZWQsIGFzc2lnbmVkIGJ1cyBudW1i ZXIgMgo+IEJVRzoga2V5IGZmZmY4ODAwNmE3ZThkMTggbm90IGluIC5kYXRhIQo+IC0tLS0tLS0t LS0tLVsgY3V0IGhlcmUgXS0tLS0tLS0tLS0tLQo+IFdBUk5JTkc6IENQVTogMCBQSUQ6IDEgYXQg a2VybmVsL2xvY2tpbmcvbG9ja2RlcC5jOjMxMzEKPiBsb2NrZGVwX2luaXRfbWFwKzB4NjBjLzB4 NzcwCj4gREVCVUdfTE9DS1NfV0FSTl9PTigxKVsgICAgMS41NjcwNDRdIE1vZHVsZXMgbGlua2Vk IGluOgo+IENQVTogMCBQSUQ6IDEgQ29tbTogc3dhcHBlci8wIE5vdCB0YWludGVkIDQuOS4wLXJj NysgIzU4Cj4gSGFyZHdhcmUgbmFtZTogUUVNVSBTdGFuZGFyZCBQQyAoaTQ0MEZYICsgUElJWCwg MTk5NiksIEJJT1MgQm9jaHMgMDEvMDEvMjAxMQo+ICBmZmZmODgwMDZiY2U2ZWI4IGZmZmZmZmZm ODFmOTZjOGEgZmZmZmZmZmYwMDAwMGEwMiAxZmZmZjEwMDBkNzljZDZhCj4gIGZmZmZlZDAwMGQ3 OWNkNjIgMDAwMDAwMDQ2YmNlNmVkOCAwMDAwMDAwMDQxYjU4YWIzIGZmZmZmZmZmODU5OGFmNDAK PiAgZmZmZmZmZmY4MWY5NjlmOCAwMDAwMDAwMDAwMDAwMDAwIDAwMDAwMDAwNDFiNThhYjMgMDAw MDAwMDAwMDAwMDIwMAo+IENhbGwgVHJhY2U6Cj4gIFs8ICAgICBpbmxpbmUgICAgID5dIF9fZHVt cF9zdGFjayBsaWIvZHVtcF9zdGFjay5jOjE1Cj4gIFs8ZmZmZmZmZmY4MWY5NmM4YT5dIGR1bXBf c3RhY2srMHgyOTIvMHgzOTggbGliL2R1bXBfc3RhY2suYzo1MQo+ICBbPGZmZmZmZmZmODEyYjgw OGY+XSBfX3dhcm4rMHgxOWYvMHgxZTAga2VybmVsL3BhbmljLmM6NTUwCj4gIFs8ZmZmZmZmZmY4 MTJiODE5NT5dIHdhcm5fc2xvd3BhdGhfZm10KzB4YzUvMHgxMTAga2VybmVsL3BhbmljLmM6NTY1 Cj4gIFs8ZmZmZmZmZmY4MTNmM2VmYz5dIGxvY2tkZXBfaW5pdF9tYXArMHg2MGMvMHg3NzAga2Vy bmVsL2xvY2tpbmcvbG9ja2RlcC5jOjMxMzEKPiAgWzxmZmZmZmZmZjgxOWU0M2Q0Pl0gX19rZXJu ZnNfY3JlYXRlX2ZpbGUrMHgxMTQvMHgyYTAgZnMva2VybmZzL2ZpbGUuYzo5NTQKPiAgWzxmZmZm ZmZmZjgxOWU2OGY1Pl0gc3lzZnNfYWRkX2ZpbGVfbW9kZV9ucysweDIyNS8weDUyMCBmcy9zeXNm cy9maWxlLmM6MzA1Cj4gIFs8ICAgICBpbmxpbmUgICAgID5dIGNyZWF0ZV9maWxlcyBmcy9zeXNm cy9ncm91cC5jOjY0Cj4gIFs8ZmZmZmZmZmY4MTllOGE4OT5dIGludGVybmFsX2NyZWF0ZV9ncm91 cCsweDIzOS8weDhmMCBmcy9zeXNmcy9ncm91cC5jOjEzNAo+ICBbPGZmZmZmZmZmODE5ZTkxNWY+ XSBzeXNmc19jcmVhdGVfZ3JvdXArMHgxZi8weDMwIGZzL3N5c2ZzL2dyb3VwLmM6MTU2Cj4gIFs8 ZmZmZmZmZmY4MzIzZGUyND5dIHZoY2lfc3RhcnQrMHg1YjQvMHg3YTAgZHJpdmVycy91c2IvdXNi aXAvdmhjaV9oY2QuYzo5NzgKPiAgWzxmZmZmZmZmZjgyYzkwN2NhPl0gdXNiX2FkZF9oY2QrMHg4 ZGEvMHgxYzYwIGRyaXZlcnMvdXNiL2NvcmUvaGNkLmM6Mjg2Nwo+ICBbPGZmZmZmZmZmODMyM2Jj NTc+XSB2aGNpX2hjZF9wcm9iZSsweDk3LzB4MTMwCj4gZHJpdmVycy91c2IvdXNiaXAvdmhjaV9o Y2QuYzoxMTAzCj4gIC0tLQo+ICAtLS0KPiAtLS1bIGVuZCB0cmFjZSBjMzNjN2IyMDJjZjNhYWM4 IF0tLS0KPiAKPiBSZXBvcnRlZC1ieTogQW5kcmV5IEtvbm92YWxvdiA8YW5kcmV5a252bEBnb29n bGUuY29tPgo+IFNpZ25lZC1vZmYtYnk6IFNodWFoIEtoYW4gPHNodWFoa2hAb3NnLnNhbXN1bmcu Y29tPgo+IC0tLQo+IAo+IEdyZWcsCj4gCj4gUGxlYXNlIGFwcGx5IHRoaXMgZml4IHRvIDQuOSBz dGFibGUuIEkgcmUtZGlzY292ZXJlZCB0aGUgcHJvYmxlbQo+IG9uIDQuOS43Ny1yYzEgYW5kIHJl LXRlc3RlZCB0aGUgcGF0Y2ggb24gaXQuCgpOb3cgcXVldWVkIHVwLCB0aGFua3MuCgpncmVnIGst aAotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vi c2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2 Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVs Lm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-3959958-1516552092-5-4616729720846010734 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516552092; b=bbYfn6X52TXk0j6KOnhepuwsCvf/JIo6+tkwH65dK5uVTNh yb6QEGaqNtbVmWmyOyg8H21avc1Uk/Apcv3N75qv4IzfyIUdLqC+xnTis7QZ/y54 9ZBRkgpZYr4oTbHGLq/urqKaweA8s7Ydcc9mXkxZgnGG6XY8KXd+PrxzeHUXCvCC EN5gVLXyvV8nlNY2sqUqYVREt2BlT5byQ4iNj+3jgfYawxViO384lQq9TDH1ocEl H6gvwiX/KoIxmgSWxlb7VEwmvn2LJ6ozmjCiVbeX92GnTMXlrK17ha7e6+4C/1ij 6sHTpXAQ8WgEFLLI7IOrrLc3J4hHlh3pOmQsAIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1516552092; bh=tU1Vabc2qP0B7wsxAVIdRYIdZy lDZGjpfl2Dvsrv7pE=; b=QUJ93CE4KkYkFzrA9mNHBY5RPcKosYJcJn3tvLTjQW 4TuxtOGmwuQIYrx9BE+HiTjKZm09lLDpROn1n81AX5rLaCEKy5zucORNlJ8+FbcN 3gVhMnUmj4pCSePGgF8rig/QHf8TTkYPOGk1IDrtjwXGZ6AtWHbViOkFw5l7TNSW KmK6WrUscwTH5sVLuJWUsNPjIa5D89KGbgDA263xHHUanCEi80hXz77ssEz92NSL JVCzjjWHjeX38Di1ZoQFVQ+B8LJBa6/VrkvlxfnLDKHt4UuC5SHUb6lJ04K6B6eI L++33VNs+ZZWAjc40Atl4lZNh15sr8nyKFfsy+rCPgYg== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751334AbeAUQ1N (ORCPT ); Sun, 21 Jan 2018 11:27:13 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:58562 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750925AbeAUQ1L (ORCPT ); Sun, 21 Jan 2018 11:27:11 -0500 Date: Sun, 21 Jan 2018 17:27:11 +0100 From: Greg KH To: Shuah Khan Cc: valentina.manea.m@gmail.com, shuah@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 4.9] usbip: fix warning in vhci_hcd_probe/lockdep_init_map Message-ID: <20180121162711.GA18144@kroah.com> References: <20180117220343.21725-1-shuahkh@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180117220343.21725-1-shuahkh@osg.samsung.com> User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Jan 17, 2018 at 03:03:43PM -0700, Shuah Khan wrote: > commit 918b8ac55b6c809b70aa05c279087109584e393e upstream > > vhci_hcd calls sysfs_create_group() with dynamically allocated sysfs > attributes triggering the lock-class key not persistent warning. Call > sysfs_attr_init() for dynamically allocated sysfs attributes to fix it. > > vhci_hcd vhci_hcd: USB/IP Virtual Host Controller > vhci_hcd vhci_hcd: new USB bus registered, assigned bus number 2 > BUG: key ffff88006a7e8d18 not in .data! > ------------[ cut here ]------------ > WARNING: CPU: 0 PID: 1 at kernel/locking/lockdep.c:3131 > lockdep_init_map+0x60c/0x770 > DEBUG_LOCKS_WARN_ON(1)[ 1.567044] Modules linked in: > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 4.9.0-rc7+ #58 > Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS Bochs 01/01/2011 > ffff88006bce6eb8 ffffffff81f96c8a ffffffff00000a02 1ffff1000d79cd6a > ffffed000d79cd62 000000046bce6ed8 0000000041b58ab3 ffffffff8598af40 > ffffffff81f969f8 0000000000000000 0000000041b58ab3 0000000000000200 > Call Trace: > [< inline >] __dump_stack lib/dump_stack.c:15 > [] dump_stack+0x292/0x398 lib/dump_stack.c:51 > [] __warn+0x19f/0x1e0 kernel/panic.c:550 > [] warn_slowpath_fmt+0xc5/0x110 kernel/panic.c:565 > [] lockdep_init_map+0x60c/0x770 kernel/locking/lockdep.c:3131 > [] __kernfs_create_file+0x114/0x2a0 fs/kernfs/file.c:954 > [] sysfs_add_file_mode_ns+0x225/0x520 fs/sysfs/file.c:305 > [< inline >] create_files fs/sysfs/group.c:64 > [] internal_create_group+0x239/0x8f0 fs/sysfs/group.c:134 > [] sysfs_create_group+0x1f/0x30 fs/sysfs/group.c:156 > [] vhci_start+0x5b4/0x7a0 drivers/usb/usbip/vhci_hcd.c:978 > [] usb_add_hcd+0x8da/0x1c60 drivers/usb/core/hcd.c:2867 > [] vhci_hcd_probe+0x97/0x130 > drivers/usb/usbip/vhci_hcd.c:1103 > --- > --- > ---[ end trace c33c7b202cf3aac8 ]--- > > Reported-by: Andrey Konovalov > Signed-off-by: Shuah Khan > --- > > Greg, > > Please apply this fix to 4.9 stable. I re-discovered the problem > on 4.9.77-rc1 and re-tested the patch on it. Now queued up, thanks. greg k-h