From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x225Ml9FHAAQP4DJu+PPmslNTJze8+SndgQUU8YGO6dPykXi2/F7vzeE/9Iik6/Ad8+eVDlOk ARC-Seal: i=1; a=rsa-sha256; t=1516611293; cv=none; d=google.com; s=arc-20160816; b=prM50IP9v5KftZxXJftExU/GeYCvihJVhJkGPbSoNrUrzi+amLthEtDTqC3M2qDR2G BPdoFZPxofR0xCyDcN0SmktC7Ucut3WYBlSEhA5M4fshM+Vi4KuDGi6NzODFCLXmdhSW x9+ngQWnpwhvNV6CVYCndUxfHJ2LU22CYGWJSxvpO1Ll5B4uv63/ejD/mpGohVe/g1wP JucZrpylurI6m6CnlFcG4BoP9R9TmEtNCadRjeDsua4bbupcrWiCaHcsSEcmzxdMpY9x /HLEwbZXhButwcEhjoK4Zmu/nHe96S/666/MuzaG0669pPTXUwQJjgifiordE/n/2wu9 KZIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:user-agent:references:in-reply-to:message-id:date :subject:cc:to:from:arc-authentication-results; bh=bvgY4W/N/ipAWyJY7l9zIiGtMDcKsiUI5Twa0usQF/4=; b=PdIOSv53k5sKoytCe5zNZkDmshqE9AJ+fHMvowfNM3G0C9sMShcexRGae7d11Eu0MH NPSClrRgRfthE4P4VZN+tRQE94kCH+fFpnLwwwsPUbT+AAfyu+JMQaeoQXKQLqECOiKe zai/3hueAKLd1kBg10CRNmBXrxWucyYGj3zHfoE64egVIZS0My65fC2L3XLbI3f4t7ON J7PBzrydiMr3Iq/ys7m1e3qcst+53in3rR7AtIKsOodHOkjO5HyYLWo+gyMJuiaN104R Cm2VWvOpAxhS8zhK5DlYYfQfO11OHfU0hermJ7hwbOUE2f8yjjCXwZ+pOnvQaxt0ySOD u/NA== ARC-Authentication-Results: i=1; mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org Authentication-Results: mx.google.com; spf=softfail (google.com: domain of transitioning gregkh@linuxfoundation.org does not designate 90.92.71.90 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johan Hovold , Peter Ujfalusi , Dmitry Torokhov Subject: [PATCH 4.9 26/47] Input: twl6040-vibra - fix child-node lookup Date: Mon, 22 Jan 2018 09:45:37 +0100 Message-Id: <20180122083927.546413338@linuxfoundation.org> X-Mailer: git-send-email 2.16.0 In-Reply-To: <20180122083925.568134913@linuxfoundation.org> References: <20180122083925.568134913@linuxfoundation.org> User-Agent: quilt/0.65 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-LABELS: =?utf-8?b?IlxcU2VudCI=?= X-GMAIL-THRID: =?utf-8?q?1590281467376099961?= X-GMAIL-MSGID: =?utf-8?q?1590282204324769457?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Johan Hovold commit dcaf12a8b0bbdbfcfa2be8dff2c4948d9844b4ad upstream. Fix child-node lookup during probe, which ended up searching the whole device tree depth-first starting at parent rather than just matching on its children. Later sanity checks on node properties (which would likely be missing) should prevent this from causing much trouble however, especially as the original premature free of the parent node has already been fixed separately (but that "fix" was apparently never backported to stable). Fixes: e7ec014a47e4 ("Input: twl6040-vibra - update for device tree support") Fixes: c52c545ead97 ("Input: twl6040-vibra - fix DT node memory management") Signed-off-by: Johan Hovold Acked-by: Peter Ujfalusi Tested-by: H. Nikolaus Schaller (on Pyra OMAP5 hardware) Signed-off-by: Dmitry Torokhov Signed-off-by: Greg Kroah-Hartman --- drivers/input/misc/twl6040-vibra.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) --- a/drivers/input/misc/twl6040-vibra.c +++ b/drivers/input/misc/twl6040-vibra.c @@ -248,8 +248,7 @@ static int twl6040_vibra_probe(struct pl int vddvibr_uV = 0; int error; - of_node_get(twl6040_core_dev->of_node); - twl6040_core_node = of_find_node_by_name(twl6040_core_dev->of_node, + twl6040_core_node = of_get_child_by_name(twl6040_core_dev->of_node, "vibra"); if (!twl6040_core_node) { dev_err(&pdev->dev, "parent of node is missing?\n");