From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Date: Mon, 22 Jan 2018 11:37:45 +0100 Subject: [lustre-devel] [PATCH 1/2] staging: lustre: Fix comment style In-Reply-To: <1516413239.14739.0.camel@perches.com> References: <20180115150259.GA17991@kroah.com> <1516290692-11642-1-git-send-email-fabian_huegel@web.de> <1516290692-11642-2-git-send-email-fabian_huegel@web.de> <1516413239.14739.0.camel@perches.com> Message-ID: <20180122103745.GA23996@kroah.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Joe Perches Cc: devel@driverdev.osuosl.org, Ben Evans , Fabian Huegel , linux-kernel@i4.cs.fau.de, NeilBrown , linux-kernel@vger.kernel.org, Oleg Drokin , lustre-devel@lists.lustre.org, Andreas Dilger , "John L . Hammond" , Lai Siyao , Christoph Volkert On Fri, Jan 19, 2018 at 05:53:59PM -0800, Joe Perches wrote: > On Thu, 2018-01-18 at 16:51 +0100, Fabian Huegel wrote: > > Most multi-line comments started on the first line, but the preferred > > linux kernel style is to start multi-line comments on the second line. > > Some comments became less readable after the change, so we changed them > > to single-line comments. > [] > > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h > > > > @@ -182,7 +179,8 @@ struct config_llog_data { > > struct obd_export *cld_mgcexp; > > struct mutex cld_lock; > > int cld_type; > > - unsigned int cld_stopping:1, /* we were told to stop > > + unsigned int cld_stopping:1, /* > > + * we were told to stop > > * watching > > */ > > cld_lostlock:1; /* lock not requeued */ > > probably better for both of these to be bool > instead of bitfield. That's a change best left for a separate patch :) thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1541842-1516617473-2-14085643783486040601 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='org', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516617473; b=wEXCGGZRTx1/Ycyu4XLsmq1z0VWWp3LhYcywTzXJuGR8lK4 /h5hx9jdhyQVBYnuscw0O8toq8CCrRnSlvwpuqlgyWTOQz16TOvxCIXH/TeAEfLm +Mwf6SXVW+Ns9Id8ArlI4aw6iLPnAEdUtaSKCn2bjG+FUGCBKeWyfFcpMzzKw9wK e3/6YPmnRwU2MfIic2FNYnFUNibCucCf5mqO0lrvlXkx5KAzzVxU0oOAFjT/YTXo LCuLB5eIqtpSIHXAta4UMaAMlljhHLYNPncaGqhdKsI9sB7N0zJBHOjELdwZoa6o lYNsQ7/UlYI6njIKLd1GAj0Z1iydqOlC0M9p8BA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1516617473; bh=v siH6+KQuLwGLLfwo9WpPaoR5rwlgrucyBmKhUE0DO0=; b=e8FSFzS/jh42Qkrl0 dZwI7LgvmxgbCmwiipxWpgFmnaTd95kmDDGIvSpPc5WVg8xGSZu6WLhu0JqAMfHj 6kZw/vVYn6pItKcUEwbnjEpR85hRCCnSI4WdQF623DPyAVq/gavY2JDiURpceK8C LGWelGmf4WFsYLZaqfP4H5Fb7O9+JMyZUZiuml34jHipIfLMfjbX5V9E4xALsO/O qZOxBQyQwXNM+GGs1z2XM8Tj7Rwmy8ucVB3+9U7gy+J0VFLWHTC8UHoOdqI3avDm iuZJQ6tyIF8IA0cAVVOFjuCawGPAWd2gbcWlC14HkFo5d0QViRBAz+wj+U+fmiEX qzRiA== ARC-Authentication-Results: i=1; mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx1.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=none (p=none,has-list-id=yes,d=none) header.from=linuxfoundation.org; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=linuxfoundation.org header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Mon, 22 Jan 2018 11:37:45 +0100 From: Greg Kroah-Hartman To: Joe Perches Subject: Re: [PATCH 1/2] staging: lustre: Fix comment style Message-ID: <20180122103745.GA23996@kroah.com> References: <20180115150259.GA17991@kroah.com> <1516290692-11642-1-git-send-email-fabian_huegel@web.de> <1516290692-11642-2-git-send-email-fabian_huegel@web.de> <1516413239.14739.0.camel@perches.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1516413239.14739.0.camel@perches.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Ben Evans , Fabian Huegel , linux-kernel@i4.cs.fau.de, NeilBrown , linux-kernel@vger.kernel.org, Oleg Drokin , lustre-devel@lists.lustre.org, Andreas Dilger , "John L . Hammond" , Lai Siyao , Christoph Volkert Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Jan 19, 2018 at 05:53:59PM -0800, Joe Perches wrote: > On Thu, 2018-01-18 at 16:51 +0100, Fabian Huegel wrote: > > Most multi-line comments started on the first line, but the preferred > > linux kernel style is to start multi-line comments on the second line. > > Some comments became less readable after the change, so we changed them > > to single-line comments. > [] > > diff --git a/drivers/staging/lustre/lustre/include/obd_class.h b/drivers/staging/lustre/lustre/include/obd_class.h > > > > @@ -182,7 +179,8 @@ struct config_llog_data { > > struct obd_export *cld_mgcexp; > > struct mutex cld_lock; > > int cld_type; > > - unsigned int cld_stopping:1, /* we were told to stop > > + unsigned int cld_stopping:1, /* > > + * we were told to stop > > * watching > > */ > > cld_lostlock:1; /* lock not requeued */ > > probably better for both of these to be bool > instead of bitfield. That's a change best left for a separate patch :) thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel