From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sudeep.Holla@arm.com
Cc: linux-pm@vger.kernel.org
Subject: [bug report] cpufreq: scpi: remove arm_big_little dependency
Date: Mon, 22 Jan 2018 13:48:23 +0300 [thread overview]
Message-ID: <20180122104823.GA25283@mwanda> (raw)
Hello Sudeep Holla,
The patch 343a8d17fa8d: "cpufreq: scpi: remove arm_big_little
dependency" from Jan 10, 2018, leads to the following static checker
warning:
drivers/cpufreq/scpi-cpufreq.c:203 scpi_cpufreq_ready()
warn: 'cdev' isn't an ERR_PTR
drivers/cpufreq/scpi-cpufreq.c
198 static void scpi_cpufreq_ready(struct cpufreq_policy *policy)
199 {
200 struct scpi_data *priv = policy->driver_data;
201 struct thermal_cooling_device *cdev;
202
203 cdev = of_cpufreq_cooling_register(policy);
204 if (!IS_ERR(cdev))
205 priv->cdev = cdev;
of_cpufreq_cooling_register() returns NULL on error. Probably just
remove the if statement?
206 }
regards,
dan carpenter
next reply other threads:[~2018-01-22 10:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 10:48 Dan Carpenter [this message]
2018-01-22 14:39 ` [bug report] cpufreq: scpi: remove arm_big_little dependency Sudeep Holla
2018-01-22 14:41 ` [PATCH] cpufreq: scpi: fix static checker warning cdev isn't an ERR_PTR Sudeep Holla
2018-01-23 2:41 ` Viresh Kumar
2018-02-08 10:06 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122104823.GA25283@mwanda \
--to=dan.carpenter@oracle.com \
--cc=Sudeep.Holla@arm.com \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.