Re: [PATCH] build: add support for vendor specific ARM cross builds

[Jerin Jacob <jerin.jacob@caviumnetworks.com>]

-----Original Message-----
> Date: Fri, 19 Jan 2018 17:35:57 +0000
> From: Bruce Richardson <bruce.richardson@intel.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> CC: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
>  thomas@monjalon.net, dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] build: add support for vendor specific ARM
>  cross builds
> User-Agent: Mutt/1.9.1 (2017-09-22)
> 
> On Fri, Jan 19, 2018 at 10:56:08PM +0530, Pavan Nikhilesh wrote:
> > On Fri, Jan 19, 2018 at 04:41:26PM +0000, Bruce Richardson wrote:
> > > On Fri, Jan 19, 2018 at 06:45:08PM +0530, Pavan Nikhilesh wrote:
> > > > Add various vendor specific cross build targets.
> > > > This can be verified by using linaro toolchain and running
> > > >
> > > > 	meson build --cross-file config/arm/arch64_armv8_<cpu>_cross
> > > >
> > >
> > > "arch64-armv8"? I thought we were standardizing on "arm64" as the naming
> > > here, or alternatively I think it should be "aarch64", right?
> > >
> > 
> > Currently, make uses "arm64-<platform>" as the naming convention.
> > I think either "arm64-<plat>" is better as we can easily represent
> > "arm-<plat>" (v7).
> > 
> Yes, keep it consistent with "make" names to avoid confusion.

+1 to keep it consistent with "make" names.

> 
> > > In terms of file naming, do we want to have a file extension on these
> > > files. I wondering if we want to change "_cross" to ".cross" for
> > > instance. The basic example in the meson docs uses a .txt extension but
> > > that looks weird to me. No strong opinion on my end, just looking for
> > > any other ideas.
> > >
> > > > In future more cross build targets can be added.
> > >
> > > Yes, good idea. Is config/<arch> the best place to hold these, or should
> > > we have a separate cross-build folder? I quite like having them in
> > > config like you have done, but wondering if anyone disagrees?
> > >
> > 
> > I split this patch out from the other series specifically so that we could
> > discuss and agree upon common name/path etc. :-).
> 
> Good idea. If no discussion or objection I'll take your patch as-is
> (with arm64 filenames) and we can always move/rename files later.
> 
> > 
> > Thanks, Pavan
> > > >
> > > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > > > --- config/arm/arch64_armv8_generic_cross  | 10 +++++++
> > > > config/arm/arch64_armv8_thunderx_cross | 13 +++++++++
> > > > config/arm/meson.build                 | 52
> > > > +++++++++++++++++++--------------- 3 files changed, 52
> > > > insertions(+), 23 deletions(-) create mode 100644
> > > > config/arm/arch64_armv8_generic_cross create mode 100644
> > > > config/arm/arch64_armv8_thunderx_cross
> > > >
> > >
> > > Adding Thomas on CC as he always has opinions on file locations and
> > > naming.
> > >
> > > /Bruce