From: Eugene Syromiatnikov <esyr@redhat.com>
To: linux-s390@vger.kernel.org, strace@vger.kernel.org
Subject: Re: [strace PATCH 04/12] Introduce s390_sthyi system call decoder
Date: Mon, 22 Jan 2018 13:29:47 +0000 [thread overview]
Message-ID: <20180122132947.GD18640@asgard.redhat.com> (raw)
In-Reply-To: <20180122131643.GB4806@osiris>
On Mon, Jan 22, 2018 at 02:16:43PM +0100, Heiko Carstens wrote:
> On Thu, Jan 18, 2018 at 07:16:44AM +0100, Eugene Syromyatnikov wrote:
> > +static void
> > +print_sthyi_hypervisor(struct tcb *tcp, struct sthyi_hypervisor *hdr,
> > + uint16_t size, int num, bool mt)
> > +{
> > + CHECK_SIZE(hdr, size, "hypervisor %d structure", num);
> > +
> > + tprintf("/* hypervisor %d */ ", num);
> > + PRINT_FIELD_0X("{", *hdr, infyflg1);
> > + if (!abbrev(tcp) && hdr->infyflg1)
> > + tprintf_comment("%s%s%s%s%#.0x%s",
> > + hdr->infyflg1 & 0x80 ?
> > + "0x80 - guest CPU usage had limiting is using "
> > + "the consumption method" : "",
> > + (hdr->infyflg1 & 0x80) && (hdr->infyflg1 & 0x40) ?
> > + ", " : "",
> > + hdr->infyflg1 & 0x40 ?
> > + "0x40 - LIMITHARD caps use prorated core time "
> ^^
> Here you have two whitespace characters (instead of one) which cause the
> s390_sthyi-v test to fail.
Uhh, sorry, I've overlooked it (on the other side, that's what are tests
for). I'll resend the patch. Thank you for the report!
parent reply other threads:[~2018-01-22 13:29 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20180122131643.GB4806@osiris>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180122132947.GD18640@asgard.redhat.com \
--to=esyr@redhat.com \
--cc=linux-s390@vger.kernel.org \
--cc=strace@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.