From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: USB TYPEC: RT1711H Type-C Chip Driver From: Guenter Roeck Message-Id: <20180122185034.GA26058@roeck-us.net> Date: Mon, 22 Jan 2018 10:50:34 -0800 To: =?utf-8?B?c2h1ZmFuX2xlZSjmnY7mm7jluIYp?= Cc: Heikki Krogerus , 'Jun Li' , ShuFanLee , =?utf-8?B?Y3lfaHVhbmco6buD5ZWf5Y6fKQ==?= , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" List-ID: T24gTW9uLCBKYW4gMjIsIDIwMTggYXQgMDI6MDE6MTNBTSArMDAwMCwgc2h1ZmFuX2xlZSjmnY7m m7jluIYpIHdyb3RlOgo+IERlYXIgSGVpa2tpIGFuZCBHdWVudGVyLAo+IAo+ICAgQmVjYXVzZSB0 aGVyZSBhcmUgc3RpbGwgb3RoZXIgY29udHJvbHMgb2YgUlQxNzExSCB0aGF0IGFyZSBkaWZmZXJl bnQgZnJvbSBzdGFuZGFyZCBUQ1BDSSwgZS54LiBmbG93IG9mIGRycCB0b2dnbGluZy4KPiAKPiAg IElzIHRoZSBzdWdnZXN0aW9uIHRvIGN1c3RvbWl6ZSB0aGUgZGlmZmVyZW5jZSBiYXNlZCBvbiB0 Y3BjaS5jIGZvciBSVDE3MTFIPwo+IAoKSW4gZ2VuZXJhbCwgSSB3b3VsZCBzYXkgeWVzLiBIb3dl dmVyLCBJIHdvbid0IGhhdmUgaW1lIHRvIHJldmlldyAKdGhlIGRpZmZlcmVuY2VzIGJldHdlZW4g dGNwY2kgYW5kIHRoZSBSVDE3MTFILiBPbiBhIGhpZ2ggbGV2ZWwsCmlmIFJUMTcxMUggY2xhaW1z IHRvIHN1cG9ydCBUQ1BDSSwgaXQgc2hvdWxkIHVzZSAob3IsIHJhdGhlciwgZXh0ZW5kKQp0aGUg VENQQ0kgZHJpdmVyLgoKTm90ZSB0aGF0IHRoZSBUQ1BDSSBkcml2ZXIgZG9lcyBub3QgY2xhaW0g dG8gYmUgY29tcGxldGU7IHRoZXJlIGlzCmEgcmVhc29uIHdoeSBpdCBpcyBzdGlsbCBpbiBzdGFn aW5nLiBIb3dldmVyLCBJIHdvdWxkIHByZWZlciBpZiBuZXcKZGV2aWNlcyBjbGFpbWluZyB0byBz dXBwb3J0IFRDUENJIHdvdWxkIHVzZSBpdCBpbnN0ZWFkIG9mIGdvaW5nCnRoZWlyIG93biB3YXku IEkgZG9uJ3QgaGF2ZSBwcm9ibGVtcyBleHRlbmRpbmcgaXQgd2l0aCBjaGlwIHNwZWNpZmljCmRl dGFpbHMgaWYgbmVlZGVkLiBTdWNoIGV4dGVuc2lvbnMgbWF5IGJlIGltcGxlbWVudGVkIGluIHRj cGNpLmMsCm9yIG1heWJlIGJldHRlciBpbiBhIGNoaXAgc3BlY2lmaWMgZmlsZS4KCkV2ZW4gaWYg eW91IGRvbid0IHVzZSB0aGUgZXhpc3RpbmcgZHJpdmVyLCBJIGRvbid0IHJlYWxseSBzZWUgd2h5 Cml0IHdvdWxkIG1ha2Ugc2Vuc2UgdG8gcmVkZWNsYXJlIGFsbCBpdHMgZGVmaW5lcy4KCkVpdGhl ciBjYXNlLCB5b3UgbWlnaHQgd2FudCB0byBydW4gY2hlY2twYXRjaCAtLXN0cmljdCBvbiB5b3Vy CmRyaXZlci4gTW9zdCBvZiB0aGF0IGl0IHJlcG9ydHMgaXMgcmVhbGx5IHVubmVjZXNzYXJ5LgpB bHNvLCBzb21lIG9mIHRoZSBjb2RlLCBzdWNoIGFzCgorI2lmbmRlZiBCSVQKKyNkZWZpbmUgQklU KHgpICgxIDw8ICh4KSkKKyNlbmRpZgoKaXMgX3JlYWxseV8gb2RkIGFuZCwgYXQgbGVhc3QgaW4g dGhpcyBjYXNlLCBzaW1wbHkgd3JvbmcuCgpHdWVudGVyCgo+IEJlc3QgUmVnYXJkcywKPiAqKioq KioqKioqKioqKioqKioqKioqKioqKioqKgo+IFNodS1GYW4gTGVlCj4gUmljaHRlayBUZWNobm9s b2d5IENvcnBvcmF0aW9uCj4gVEVMOiArODg2LTMtNTUyNjc4OSAjMjM1OQo+IEZBWDogKzg4Ni0z LTU1MjY2MTIKPiAqKioqKioqKioqKioqKioqKioqKioqKioqKioqKgo+IAo+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tCj4gRnJvbTogR3VlbnRlciBSb2VjayBbbWFpbHRvOmdyb2VjazdAZ21h aWwuY29tXSBPbiBCZWhhbGYgT2YgR3VlbnRlciBSb2Vjawo+IFNlbnQ6IFNhdHVyZGF5LCBKYW51 YXJ5IDIwLCAyMDE4IDEyOjAzIEFNCj4gVG86IEhlaWtraSBLcm9nZXJ1cwo+IENjOiBzaHVmYW5f bGVlKOadjuabuOW4hik7ICdKdW4gTGknOyBTaHVGYW5MZWU7IGN5X2h1YW5nKOm7g+WVn+WOnyk7 IGxpbnV4LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmc7IGxpbnV4LXVzYkB2Z2VyLmtlcm5lbC5vcmcK PiBTdWJqZWN0OiBSZTogW1BBVENIXSBVU0IgVFlQRUM6IFJUMTcxMUggVHlwZS1DIENoaXAgRHJp dmVyCj4gCj4gT24gRnJpLCBKYW4gMTksIDIwMTggYXQgMTE6MjQ6MTNBTSArMDIwMCwgSGVpa2tp IEtyb2dlcnVzIHdyb3RlOgo+ID4gSGksCj4gPgo+ID4gT24gRnJpLCBKYW4gMTksIDIwMTggYXQg MDk6MDE6MjRBTSArMDAwMCwgc2h1ZmFuX2xlZSg/Pz8/P3wpIHdyb3RlOgo+ID4gPiBIaSBIZWlr a2ksCj4gPiA+Cj4gPiA+ICAgRm9yIGV4YW1wbGUsIHRoZSBmbG93IG9mIHRjcGNpX2luaXQgaXMg YSBsaXR0bGUgYml0IGRpZmZlcmVudC4KPiA+ID4gICBJbiB0Y3BjaV9pbml0LCB0aGVyZSBhcmUg bW9yZSBwYXJhbWV0ZXJzIG5lZWQgdG8gYmUgc2V0IGZvciBSVDE3MTFILgo+ID4KPiA+IERpZmZl cmVudCBpbml0IHBhcmFtZXRlcnMgaXMgcmVhbGx5IG5vdCBhIHJlYXNvbiBmb3IgYSBmb3JrIG9m IHRoZQo+ID4gZHJpdmVyLiBUaGUgY29uZmlndXJhdGlvbiBvZiB0aGUgVENQQyB3aWxsIGRlcGVu ZCBvbiB0aGUgcGxhdGZvcm0gYW5kCj4gPiBUQ1BDIHZlbmRvciBtb3N0IGNhc2VzLgo+ID4KPiBB Z3JlZWQuIGR3YzMgdXNiIHN1cHBvcnQgaXMgYW4gZXhjZWxsZW50IGV4YW1wbGUgb24gaG93IHRv IGhhbmRsZSB0aGlzIGtpbmQgb2YgdmFyaWF0aW9uLgo+IAo+IEd1ZW50ZXIKPiAqKioqKioqKioq KioqIEVtYWlsIENvbmZpZGVudGlhbGl0eSBOb3RpY2UgKioqKioqKioqKioqKioqKioqKioKPiAK PiBUaGUgaW5mb3JtYXRpb24gY29udGFpbmVkIGluIHRoaXMgZS1tYWlsIG1lc3NhZ2UgKGluY2x1 ZGluZyBhbnkgYXR0YWNobWVudHMpIG1heSBiZSBjb25maWRlbnRpYWwsIHByb3ByaWV0YXJ5LCBw cml2aWxlZ2VkLCBvciBvdGhlcndpc2UgZXhlbXB0IGZyb20gZGlzY2xvc3VyZSB1bmRlciBhcHBs aWNhYmxlIGxhd3MuIEl0IGlzIGludGVuZGVkIHRvIGJlIGNvbnZleWVkIG9ubHkgdG8gdGhlIGRl c2lnbmF0ZWQgcmVjaXBpZW50KHMpLiBBbnkgdXNlLCBkaXNzZW1pbmF0aW9uLCBkaXN0cmlidXRp b24sIHByaW50aW5nLCByZXRhaW5pbmcgb3IgY29weWluZyBvZiB0aGlzIGUtbWFpbCAoaW5jbHVk aW5nIGl0cyBhdHRhY2htZW50cykgYnkgdW5pbnRlbmRlZCByZWNpcGllbnQocykgaXMgc3RyaWN0 bHkgcHJvaGliaXRlZCBhbmQgbWF5IGJlIHVubGF3ZnVsLiBJZiB5b3UgYXJlIG5vdCBhbiBpbnRl bmRlZCByZWNpcGllbnQgb2YgdGhpcyBlLW1haWwsIG9yIGJlbGlldmUgdGhhdCB5b3UgaGF2ZSBy ZWNlaXZlZCB0aGlzIGUtbWFpbCBpbiBlcnJvciwgcGxlYXNlIG5vdGlmeSB0aGUgc2VuZGVyIGlt bWVkaWF0ZWx5IChieSByZXBseWluZyB0byB0aGlzIGUtbWFpbCksIGRlbGV0ZSBhbnkgYW5kIGFs bCBjb3BpZXMgb2YgdGhpcyBlLW1haWwgKGluY2x1ZGluZyBhbnkgYXR0YWNobWVudHMpIGZyb20g eW91ciBzeXN0ZW0sIGFuZCBkbyBub3QgZGlzY2xvc2UgdGhlIGNvbnRlbnQgb2YgdGhpcyBlLW1h aWwgdG8gYW55IG90aGVyIHBlcnNvbi4gVGhhbmsgeW91IQotLS0KVG8gdW5zdWJzY3JpYmUgZnJv bSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxpbmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhl IGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1ham9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpv cmRvbW8gaW5mbyBhdCAgaHR0cDovL3ZnZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1s Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2127129-1516647054-2-9284023354064041576 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='net', MailFrom='org' X-Spam-charsets: to='utf-8', cc='utf-8', plain='utf-8' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: linux-usb-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1516647054; b=prPzR0U1YSvB7CBonb81OBPGALM/DvcNhvLTh2G4ju3ZDcJ ZDoufBQmr5wfoFBfyjkTruCuKP0+Iweizz8dzvWfWMI5nzsTGJ0Lg7NIAfo+kNHj iDOTboMAdiEC3IJs6m4ObTVa9S2h03KFr7bk0HeYidMoDX6BTE1pPwpEqh9sz6QN gW6tINeCRRFC20is9SKDPyskRQNMWLeWe3B2w/fXenLlDtpK+EK/gTibJaNzrWzu tOKweKCSYw8ZmG92TB4x+Ki2fCBsEzs88Wwsvs1vuKSJYLnGCkTbxN5VMMzG4zLH 9jALQsWt0jNYja/qIrGW9ej+Tz9iOdHkL2cGYaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:content-transfer-encoding :in-reply-to:sender:list-id; s=arctest; t=1516647054; bh=SEALwZc Aepg5sxmRtM477CapV4uj7mFCGPoDl1aMvP0=; b=v1SlFjSGvo4KYk46nX+90o8 XNp9+uEBzUYou9llcGaPrdcwhAJ/n7SktiodubTW+vHE+WyWrgeanGtr9qCYOuoF skPe7FcbsGEtUdzpwnMsvkG9zNDAIMAcfx7JierZfShpm6aKLNkMmQirN05PmES3 hN+SgFHn6RSAOV9Cc10/4JR+pRQ8KKTgke6uRBrHue5x8vRgt8g8MobpzXE2FPKW jvptegNE4YQBdg+LXzYCZsL3zHkKladS8S660kT0k4qLX7nFDl6pVOqSGVN+sAz+ +8Fs5H5DzjXm2d1ZG3qjR2r99DQ2go393Rp8g0of15z117uBFWqbFGUbEWQpTEg= = ARC-Authentication-Results: i=1; mx4.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=FXS86mju x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=roeck-us.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=gV0Lu3my; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=roeck-us.net header.result=pass header_is_org_domain=yes Authentication-Results: mx4.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=gmail.com header.i=@gmail.com header.b=FXS86mju x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=20161025; dmarc=none (p=none,has-list-id=yes,d=none) header.from=roeck-us.net; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=linux-usb-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-google-dkim=fail (message has been altered; 2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=gV0Lu3my; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=roeck-us.net header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751200AbeAVSuk (ORCPT ); Mon, 22 Jan 2018 13:50:40 -0500 Received: from mail-pg0-f47.google.com ([74.125.83.47]:40596 "EHLO mail-pg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbeAVSuh (ORCPT ); Mon, 22 Jan 2018 13:50:37 -0500 X-Google-Smtp-Source: AH8x227kB89enxh/NVDQ87yWj3P4KRV5EDtgeV1FV/JgsTHNzJZLJ0xCeX102SS8FDYQFkE4RVHZPw== Date: Mon, 22 Jan 2018 10:50:34 -0800 From: Guenter Roeck To: =?utf-8?B?c2h1ZmFuX2xlZSjmnY7mm7jluIYp?= Cc: Heikki Krogerus , 'Jun Li' , ShuFanLee , =?utf-8?B?Y3lfaHVhbmco6buD5ZWf5Y6fKQ==?= , "linux-kernel@vger.kernel.org" , "linux-usb@vger.kernel.org" Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver Message-ID: <20180122185034.GA26058@roeck-us.net> References: <1515567552-7692-1-git-send-email-leechu729@gmail.com> <20180119082218.GA22976@kuha.fi.intel.com> <25ced79e8ea84908bf6110a613ed81a2@ex1.rt.l> <20180119092413.GB22976@kuha.fi.intel.com> <20180119160235.GA21066@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-usb-owner@vger.kernel.org X-Mailing-List: linux-usb@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Jan 22, 2018 at 02:01:13AM +0000, shufan_lee(李書帆) wrote: > Dear Heikki and Guenter, > > Because there are still other controls of RT1711H that are different from standard TCPCI, e.x. flow of drp toggling. > > Is the suggestion to customize the difference based on tcpci.c for RT1711H? > In general, I would say yes. However, I won't have ime to review the differences between tcpci and the RT1711H. On a high level, if RT1711H claims to suport TCPCI, it should use (or, rather, extend) the TCPCI driver. Note that the TCPCI driver does not claim to be complete; there is a reason why it is still in staging. However, I would prefer if new devices claiming to support TCPCI would use it instead of going their own way. I don't have problems extending it with chip specific details if needed. Such extensions may be implemented in tcpci.c, or maybe better in a chip specific file. Even if you don't use the existing driver, I don't really see why it would make sense to redeclare all its defines. Either case, you might want to run checkpatch --strict on your driver. Most of that it reports is really unnecessary. Also, some of the code, such as +#ifndef BIT +#define BIT(x) (1 << (x)) +#endif is _really_ odd and, at least in this case, simply wrong. Guenter > Best Regards, > ***************************** > Shu-Fan Lee > Richtek Technology Corporation > TEL: +886-3-5526789 #2359 > FAX: +886-3-5526612 > ***************************** > > -----Original Message----- > From: Guenter Roeck [mailto:groeck7@gmail.com] On Behalf Of Guenter Roeck > Sent: Saturday, January 20, 2018 12:03 AM > To: Heikki Krogerus > Cc: shufan_lee(李書帆); 'Jun Li'; ShuFanLee; cy_huang(黃啟原); linux-kernel@vger.kernel.org; linux-usb@vger.kernel.org > Subject: Re: [PATCH] USB TYPEC: RT1711H Type-C Chip Driver > > On Fri, Jan 19, 2018 at 11:24:13AM +0200, Heikki Krogerus wrote: > > Hi, > > > > On Fri, Jan 19, 2018 at 09:01:24AM +0000, shufan_lee(?????|) wrote: > > > Hi Heikki, > > > > > > For example, the flow of tcpci_init is a little bit different. > > > In tcpci_init, there are more parameters need to be set for RT1711H. > > > > Different init parameters is really not a reason for a fork of the > > driver. The configuration of the TCPC will depend on the platform and > > TCPC vendor most cases. > > > Agreed. dwc3 usb support is an excellent example on how to handle this kind of variation. > > Guenter > ************* Email Confidentiality Notice ******************** > > The information contained in this e-mail message (including any attachments) may be confidential, proprietary, privileged, or otherwise exempt from disclosure under applicable laws. It is intended to be conveyed only to the designated recipient(s). Any use, dissemination, distribution, printing, retaining or copying of this e-mail (including its attachments) by unintended recipient(s) is strictly prohibited and may be unlawful. If you are not an intended recipient of this e-mail, or believe that you have received this e-mail in error, please notify the sender immediately (by replying to this e-mail), delete any and all copies of this e-mail (including any attachments) from your system, and do not disclose the content of this e-mail to any other person. Thank you!