From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch v9 4/4] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface
Date: Mon, 22 Jan 2018 19:51:24 -0800 [thread overview]
Message-ID: <20180123035124.GB24956@fury> (raw)
In-Reply-To: <20180123034946.GA24956@fury>
On Mon, Jan 22, 2018 at 07:49:46PM -0800, Darren Hart wrote:
> On Wed, Jan 17, 2018 at 06:21:56PM +0000, Vadim Pasternak wrote:
> > +#define MLXREG_CORE_LABEL_MAX_SIZE 32
> > +
> > /**
> > * struct mlxreg_hotplug_device - I2C device data:
> > + *
> > * @adapter: I2C device adapter;
> > * @client: I2C device client;
> > * @brdinfo: device board information;
> > * @nr: I2C device adapter number, to which device is to be attached;
> > - * @np - pointer to node platform associated with attribute;
>
> We just added this in 3/4. This should have just been skipped and done as it is
> here directly, and only enabling ARM support at the end.
Apologies, I was still working on this email when I accidentally sent it instead
of postponing it. The above is true, but I'm working on fixing it in my branch.
No need to resend at this point.
--
Darren Hart
VMware Open Source Technology Center
next prev parent reply other threads:[~2018-01-23 3:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-17 18:21 [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Vadim Pasternak
2018-01-17 18:21 ` [patch v9 1/4] platform/x86: Move Mellanox hardware platform hotplug driver to platform/mellanox Vadim Pasternak
2018-01-23 3:51 ` Darren Hart
2018-01-17 18:21 ` [patch v9 2/4] platform/mellanox: mlxreg-hotplug: Allow driver for ARM architecture Vadim Pasternak
2018-01-17 18:21 ` [patch v9 3/4] platform/mellanox: mlxreg-hotplug: Code cleanup Vadim Pasternak
2018-01-23 3:53 ` Darren Hart
2018-01-23 4:03 ` Darren Hart
2018-01-17 18:21 ` [patch v9 4/4] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface Vadim Pasternak
2018-01-23 3:49 ` Darren Hart
2018-01-23 3:51 ` Darren Hart [this message]
2018-01-23 4:13 ` [patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug Darren Hart
2018-01-23 18:04 ` Vadim Pasternak
2018-01-23 21:54 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123035124.GB24956@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.