From: Dan Carpenter <dan.carpenter-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
To: treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [bug report] drm/tegra: Add Tegra186 display hub support
Date: Tue, 23 Jan 2018 11:34:35 +0300 [thread overview]
Message-ID: <20180123083434.GD10091@mwanda> (raw)
Hello Thierry Reding,
This is a semi-automatic email about new static checker warnings.
The patch c4755fb9064f: "drm/tegra: Add Tegra186 display hub support"
from Nov 13, 2017, leads to the following Smatch complaint:
drivers/gpu/drm/tegra/hub.c:375 tegra_shared_plane_atomic_disable()
warn: variable dereferenced before check 'old_state' (see line 370)
drivers/gpu/drm/tegra/hub.c
369 {
370 struct tegra_dc *dc = to_tegra_dc(old_state->crtc);
^^^^^^^^^^^^^^^
Deref
371 struct tegra_plane *p = to_tegra_plane(plane);
372 u32 value;
373
374 /* rien ne va plus */
375 if (!old_state || !old_state->crtc)
^^^^^^^^^
Check too late.
376 return;
377
regards,
dan carpenter
reply other threads:[~2018-01-23 8:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123083434.GD10091@mwanda \
--to=dan.carpenter-qhclzuegtsvqt0dzr+alfa@public.gmane.org \
--cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.