All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Shreeya Patel <shreeya.patel23498@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/4] Staging: rtl8723bs: Change names to conform to the kernel code
Date: Tue, 23 Jan 2018 11:45:44 +0100	[thread overview]
Message-ID: <20180123104544.GA17245@kroah.com> (raw)
In-Reply-To: <95d618c692c8c501adf321cc416234b47e17ca41.1516386028.git.shreeya.patel23498@gmail.com>

On Sat, Jan 20, 2018 at 12:10:55AM +0530, Shreeya Patel wrote:
> Change names of some variables and functions to conform
> to the kernel coding style. The changes include some removal
> of CamelCase warnings and renaming the variable and field names
> that encode their type (eg the pointers seem to start with p).
> 
> Signed-off-by: Shreeya Patel <shreeya.patel23498@gmail.com>
> ---
> 
> Changes in v3
>   -Edit the commit message.
> 
>  drivers/staging/rtl8723bs/hal/sdio_ops.c | 714 +++++++++++++++----------------
>  1 file changed, 357 insertions(+), 357 deletions(-)

Please always test-build your patches so you don't get grumpy emails
from kernel maintainers saying your patch breaks the build :(

This give me the following error when applied:

ERROR: "DisableInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: "EnableInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: "InitInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: "InitSysInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!

Please fix up and resend.

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2018-01-23 10:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19 18:33 [PATCH v3 0/4] Remove checkpatch warnings Shreeya Patel
2018-01-19 18:36 ` [PATCH v3 1/4] Staging: rtl8723bs: Replace true with x and false with !x Shreeya Patel
2018-01-19 18:40 ` [PATCH v3 2/4] Staging: rtl8723bs: Change names to conform to the kernel code Shreeya Patel
2018-01-23 10:45   ` Greg KH [this message]
2018-01-19 18:43 ` [PATCH v3 3/4] Staging: rtl8723bs: Remove dead code Shreeya Patel
2018-01-19 18:45 ` [PATCH v3 4/4] Staging: rtl8723bs: Use !x instead of NULL comparison Shreeya Patel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180123104544.GA17245@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shreeya.patel23498@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.