From: Dan Carpenter <dan.carpenter@oracle.com>
To: stoth@hauppauge.com
Cc: linux-media@vger.kernel.org
Subject: [bug report] V4L/DVB(7872): mxl5005s: checkpatch.pl compliance
Date: Tue, 23 Jan 2018 13:50:33 +0300 [thread overview]
Message-ID: <20180123105033.GA13590@mwanda> (raw)
Hello Steven Toth,
The patch d211017b9544: "V4L/DVB(7872): mxl5005s: checkpatch.pl
compliance" from May 1, 2008, leads to the following static checker
warning:
drivers/media/tuners/mxl5005s.c:1817 MXL_BlockInit()
warn: both sides of ternary the same: '1'
drivers/media/tuners/mxl5005s.c
1812 }
1813
1814 /* Charge Pump Control Dig Ana */
1815 status += MXL_ControlWrite(fe, RFSYN_CHP_GAIN, state->Mode ? 5 : 8);
1816 status += MXL_ControlWrite(fe,
1817 RFSYN_EN_CHP_HIGAIN, state->Mode ? 1 : 1);
^^^^^^^^^^^^^^^^^^^
1818 status += MXL_ControlWrite(fe, EN_CHP_LIN_B, state->Mode ? 0 : 0);
^^^^^^^^^^^^^^^^^^^
What do these mean? What are they supposed to do?
1819
regards,
dan carpenter
reply other threads:[~2018-01-23 10:50 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123105033.GA13590@mwanda \
--to=dan.carpenter@oracle.com \
--cc=linux-media@vger.kernel.org \
--cc=stoth@hauppauge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.