From: Jean Delvare <jdelvare@suse.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-i2c@vger.kernel.org
Subject: Re: [PATCH i2c-tools] i2c-dev.h: copy over typo fix from kernel include
Date: Tue, 23 Jan 2018 14:34:27 +0100 [thread overview]
Message-ID: <20180123143427.08069ff9@endymion> (raw)
In-Reply-To: <20180119092158.o6x7wy4epnzddv5y@katana>
On Fri, 19 Jan 2018 10:21:58 +0100, Wolfram Sang wrote:
> > 652619121974 ("i2c-dev.h: Minimize differences with kernel flavor".) At
> > this point i2c-tools' i2c-dev.h and the kernel's i2c-dev.h are exactly
> > the same file, modulo the difference you just pointed out.
>
> Exactly. I wanted to follow up in minimizing the differences. But I was
> unaware of the master plan...
>
> > So the right thing to do is to delete include/linux/i2c-dev.h from
> > i2c-tools altogether. We no longer use it and we no longer install it,
> > so it should be a straightforward change. I simply forgot to do it
> > after the library conversion.
>
> ... which I super like very much!
>
> Acked-by: Wolfram Sang <wsa@the-dreams.de>
Thanks, done.
https://git.kernel.org/pub/scm/utils/i2c-tools/i2c-tools.git/commit/?id=226bc03acca44cf4b300597308064c44676b6f4b
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2018-01-23 13:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-15 20:40 [PATCH i2c-tools] i2c-dev.h: copy over typo fix from kernel include Wolfram Sang
2018-01-19 8:37 ` Jean Delvare
2018-01-19 9:21 ` Wolfram Sang
2018-01-23 13:34 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180123143427.08069ff9@endymion \
--to=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.