Re: [PATCH] PM / Domains: Fixup domain-idle-states OF parsing

[Lina Iyer <ilina@codeaurora.org>]

Hi Ulf,

Thanks for the fix. The allocation is more than what is needed and this
will fix that.

On Tue, Jan 23 2018 at 10:23 +0000, Ulf Hansson wrote:
>but also makes of_genpd_parse_idle_states() to return the wrong number of
>allocated elements to the caller.
>
How is this happening?

>
>Fixes: b539cc82d493 ("PM / Domains: Ignore domain-idle-states that are not compatible")
>Cc: Lina Iyer <ilina@codeaurora.org>
>Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>---
> drivers/base/power/domain.c | 76 +++++++++++++++++++++++++++------------------
> 1 file changed, 45 insertions(+), 31 deletions(-)
>
>-	/* Loop over the phandles until all the requested entry is found */
>-	of_for_each_phandle(&it, err, dn, "domain-idle-states", NULL, 0) {
>-		np = it.node;
>-		match_id = of_match_node(idle_state_match, np);
>-		if (!match_id)
>-			continue;
>-		ret = genpd_parse_state(&st[i++], np);
This increments only if the state node matches the compatible.

>-		if (ret) {
>-			pr_err
>-			("Parsing idle state node %pOF failed with err %d\n",
>-							np, ret);
>-			of_node_put(np);
>-			kfree(st);
>-			return ret;
>-		}
>+	ret = genpd_iterate_idle_states(dn, st);
>+	if (ret <= 0) {
>+		kfree(st);
>+		return ret < 0 ? ret : -EINVAL;
> 	}
>
>-	*n = i;
Returns the count of matched state nodes.

What am I missing?

-- Lina