From: Jiri Olsa <jolsa@redhat.com>
To: Jin Yao <yao.jin@linux.intel.com>
Cc: mathieu.poirier@linaro.org, acme@kernel.org, jolsa@kernel.org,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, Linux-kernel@vger.kernel.org,
ak@linux.intel.com, kan.liang@intel.com, yao.jin@intel.com
Subject: Re: [PATCH v2] perf util: Use target->per_thread and target->system_wide flags
Date: Wed, 24 Jan 2018 08:28:42 +0100 [thread overview]
Message-ID: <20180124072842.GA8473@krava> (raw)
In-Reply-To: <1516785576-9815-1-git-send-email-yao.jin@linux.intel.com>
On Wed, Jan 24, 2018 at 05:19:36PM +0800, Jin Yao wrote:
> Mathieu Poirier reports issue in commit ("73c0ca1eee3d perf thread_map:
> Enumerate all threads from /proc") that it has negative impact on
> 'perf record --per-thread'. It has the effect of creating a kernel event
> for each thread in the system for 'perf record --per-thread'.
>
> Mathieu Poirier's patch ("perf util: Do not reuse target->per_thread flag")
> can fix this issue by creating a new target->all_threads flag.
>
> This patch is based on Mathieu Poirier's patch but it doesn't use a new
> target->all_threads flag. This patch just uses 'target->per_thread &&
> target->system_wide' as a condition to check for all threads case.
>
> v2:
> ---
> According to Jiri's comment, add description to explain why the patch
> uses 'target->per_thread && target->system_wide'.
>
> v2 doesn't have functional change.
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
prev parent reply other threads:[~2018-01-24 7:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 9:19 [PATCH v2] perf util: Use target->per_thread and target->system_wide flags Jin Yao
2018-01-24 7:28 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124072842.GA8473@krava \
--to=jolsa@redhat.com \
--cc=Linux-kernel@vger.kernel.org \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@intel.com \
--cc=mathieu.poirier@linaro.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=yao.jin@intel.com \
--cc=yao.jin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.