From: Stephen Hemminger <stephen@networkplumber.org>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dev@dpdk.org, Matan Azrad <matan@mellanox.com>,
Thomas Monjalon <thomas@monjalon.net>,
Olga Shern <olgas@mellanox.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
stable@dpdk.org
Subject: Re: [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic
Date: Wed, 24 Jan 2018 07:39:15 -0800 [thread overview]
Message-ID: <20180124073915.753a4764@xeon-e3> (raw)
In-Reply-To: <1516803133-17529-1-git-send-email-ophirmu@mellanox.com>
On Wed, 24 Jan 2018 14:12:13 +0000
Ophir Munk <ophirmu@mellanox.com> wrote:
> Remove CFLAGS -std=c11 and -pedantic in order to guarantee
> a successful vdev_netvsc compilation on old Linux distributions.
> Otherwise old GCC compilers may complain as follows:
> cc1: error: unrecognized command line option -std=c11
>
> Fixes: 6086ab3bb3d2 ("net/vdev_netvsc: introduce Hyper-V platform driver")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
> ---
> drivers/net/vdev_netvsc/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/vdev_netvsc/Makefile b/drivers/net/vdev_netvsc/Makefile
> index f2b2ac5..45351b8 100644
> --- a/drivers/net/vdev_netvsc/Makefile
> +++ b/drivers/net/vdev_netvsc/Makefile
> @@ -12,7 +12,7 @@ EXPORT_MAP := rte_pmd_vdev_netvsc_version.map
> # Additional compilation flags.
> CFLAGS += -O3
> CFLAGS += -g
> -CFLAGS += -std=c11 -pedantic -Wall -Wextra
> +CFLAGS += -Wall -Wextra
> CFLAGS += -D_XOPEN_SOURCE=600
> CFLAGS += -D_BSD_SOURCE
> CFLAGS += -D_DEFAULT_SOURCE
Why did this driver not use $(WERROR) like rest of DPDK drivers.
next prev parent reply other threads:[~2018-01-24 15:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 11:19 [PATCH v1] net/vdev_netvsc: remove CFLAGS -std=c11 and -pedantic Ophir Munk
2018-01-24 12:48 ` Matan Azrad
2018-01-24 14:12 ` [PATCH v2] net/vdev_netvsc: fix build using C11 mode and pedantic Ophir Munk
2018-01-24 14:45 ` Matan Azrad
2018-01-24 18:06 ` Thomas Monjalon
2018-01-24 15:39 ` Stephen Hemminger [this message]
2018-01-24 18:08 ` [dpdk-stable] " Thomas Monjalon
2018-01-24 18:27 ` Stephen Hemminger
2018-01-25 8:24 ` Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124073915.753a4764@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=olgas@mellanox.com \
--cc=ophirmu@mellanox.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.