From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Date: Wed, 24 Jan 2018 08:47:31 +0100 Subject: [U-Boot] [PATCH 2/8] spl: nand: sunxi: Fix second case of modulo by zero error In-Reply-To: <20180124004454.5759-3-miquel.raynal@free-electrons.com> References: <20180124004454.5759-1-miquel.raynal@free-electrons.com> <20180124004454.5759-3-miquel.raynal@free-electrons.com> Message-ID: <20180124074731.7olf475c2d7ne7co@flea.lan> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Jan 24, 2018 at 01:44:48AM +0100, Miquel Raynal wrote: > In the nand_read_buffer() step, the seed is calculated by doing a modulo > by conf->nseeds which is always zero when not using the randomizer (most > of SLC NANDs). > > This situation turns out to lead to a run time freeze. > > Derive this seed only when the randomizer is enabled (and conf->nseeds > logically not zero). Mentionning the first occurence of that issue in your commit log would be great, especially since the situation depends on configuration options. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 833 bytes Desc: not available URL: