From: Peter Zijlstra <peterz@infradead.org>
To: Lin Xiulei <linxiulei@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>,
mingo@redhat.com, acme@kernel.org,
alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, Stephane Eranian <eranian@gmail.com>,
torvalds@linux-foundation.org, linux-perf-users@vger.kernel.org,
Brendan Gregg <brendan.d.gregg@gmail.com>,
yang_oliver@hotmail.com, jinli.zjl@alibaba-inc.com,
"leilei.lin" <leilei.lin@alibaba-inc.com>
Subject: Re: [PATCH v2] perf/core: Fix installing cgroup event into cpu
Date: Wed, 24 Jan 2018 10:46:36 +0100 [thread overview]
Message-ID: <20180124094636.GP2228@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CALPjY3mZYSs-8Bg0U0kq=jPz+TX8RxfpvBeVs6oxspfwLjOjfA@mail.gmail.com>
On Wed, Jan 24, 2018 at 05:19:34PM +0800, Lin Xiulei wrote:
> Sure, and I consider this "OK" works for "What goes wrong if we leave
> it set?". : )
It would be good if you inspect the code for the case of leaving
cpuctx->cgrp set with no cgroup events left -- AND -- put a blurb about
what you found in your new Changelog.
I suspect it works out and something like perf_cgroup_switch() will fix
things up for us later, but double check and test.
next prev parent reply other threads:[~2018-01-24 9:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 7:50 [PATCH v2] perf/core: Fix installing cgroup event into cpu linxiulei
2018-01-24 8:20 ` Peter Zijlstra
2018-01-24 8:32 ` Lin Xiulei
2018-01-24 9:14 ` Peter Zijlstra
2018-01-24 9:19 ` Lin Xiulei
2018-01-24 9:46 ` Peter Zijlstra [this message]
2018-01-24 9:59 ` Lin Xiulei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124094636.GP2228@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=brendan.d.gregg@gmail.com \
--cc=eranian@gmail.com \
--cc=jinli.zjl@alibaba-inc.com \
--cc=jolsa@redhat.com \
--cc=leilei.lin@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=linxiulei@gmail.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=yang_oliver@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.