From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: KVM <kvm@vger.kernel.org>,
linux-s390 <linux-s390@vger.kernel.org>,
Janosch Frank <frankja@linux.vnet.ibm.com>,
David Hildenbrand <david@redhat.com>,
Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
Subject: Re: [PATCH v2] KVM: s390: add proper locking for CMMA migration bitmap
Date: Wed, 24 Jan 2018 15:21:44 +0100 [thread overview]
Message-ID: <20180124152144.4ba21dca.cohuck@redhat.com> (raw)
In-Reply-To: <20180124124100.15690-1-borntraeger@de.ibm.com>
On Wed, 24 Jan 2018 13:41:00 +0100
Christian Borntraeger <borntraeger@de.ibm.com> wrote:
> Some parts of the cmma migration bitmap is already protected
> with the kvm->lock (e.g. the migration start). On the other
> hand the read of the cmma bits is not protected against a
> concurrent free, neither is the emulation of the ESSA instruction.
> Let's extend the locking to all related ioctls by using
> the slots lock and wait for the freeing until all unlocked
> users have finished (those hold kvm->srcu for read).
>
> Reported-by: David Hildenbrand <david@redhat.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> Cc: stable@vger.kernel.org # 4.13+
> Fixes: 190df4a212a7 (KVM: s390: CMMA tracking, ESSA emulation, migration mode)
> Reviewed-by: Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>
> ---
> v1->v2: fix comments in kvm_s390_vm_[start|stop]_migration
> arch/s390/kvm/kvm-s390.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
prev parent reply other threads:[~2018-01-24 14:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 12:41 [PATCH v2] KVM: s390: add proper locking for CMMA migration bitmap Christian Borntraeger
2018-01-24 12:51 ` David Hildenbrand
2018-01-24 12:51 ` Christian Borntraeger
2018-01-24 12:54 ` David Hildenbrand
2018-01-24 13:02 ` Christian Borntraeger
2018-01-24 13:05 ` David Hildenbrand
2018-01-24 13:08 ` Christian Borntraeger
2018-01-24 14:17 ` Cornelia Huck
2018-01-24 14:21 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124152144.4ba21dca.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=frankja@linux.vnet.ibm.com \
--cc=imbrenda@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.