From: Andi Kleen <ak@linux.intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Kosina <jikos@kernel.org>,
torvalds@linux-foundation.org,
Thomas Gleixner <tglx@linutronix.de>,
David Woodhouse <dwmw@amazon.co.uk>,
rusty@rustcorp.com.au, arjan.van.de.ven@intel.com,
jeyu@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Revert "module: Add retpoline tag to VERMAGIC"
Date: Wed, 24 Jan 2018 07:44:01 -0800 [thread overview]
Message-ID: <20180124154401.GA26209@tassilo.jf.intel.com> (raw)
In-Reply-To: <20180124142817.GA23797@kroah.com>
On Wed, Jan 24, 2018 at 03:28:17PM +0100, Greg Kroah-Hartman wrote:
> This reverts commit 6cfb521ac0d5b97470883ff9b7facae264b7ab12.
>
> Turns out distros do not want to make retpoline as part of their "ABI",
> so this patch should not have been merged. Sorry Andi, this was my
> fault, I suggested it when your original patch was the "correct" way of
> doing this instead.
It's ok for me to revert, but if it's reverted should consider
the warning only patch version instead.
https://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git/commit/?h=spec/retpoline-module-2&id=b40b7c1dbffaa636906b774ef5519882060e1aa0
I had posted that earlier, but reviewers in the end preferred
the simple modversions variant.
I think we should have something at least for 4.15 to catch mistakes.
-Andi
next prev parent reply other threads:[~2018-01-24 15:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 14:28 [PATCH] Revert "module: Add retpoline tag to VERMAGIC" Greg Kroah-Hartman
2018-01-24 15:44 ` Andi Kleen [this message]
2018-01-24 17:00 ` Linus Torvalds
2018-01-24 18:17 ` Andi Kleen
2018-01-24 19:21 ` Randy Dunlap
2018-01-24 19:31 ` David Woodhouse
2018-01-25 8:43 ` Thomas Gleixner
2018-01-26 0:20 ` Jessica Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124154401.GA26209@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=arjan.van.de.ven@intel.com \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=jeyu@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.