All of lore.kernel.org
 help / color / mirror / Atom feed
From: oleg@redhat.com (Oleg Nesterov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/7] arm64: uprobes - ARM32 instruction probing
Date: Wed, 24 Jan 2018 17:13:38 +0100	[thread overview]
Message-ID: <20180124161338.GA23561@redhat.com> (raw)
In-Reply-To: <1516797274-20320-8-git-send-email-m.slodczyk2@partner.samsung.com>

On 01/24, Maciej Slodczyk wrote:
>
> Detect what kind of instruction is being probed and depending on the result:
> - if an A64 instruction handle it the old way, using existing A64 instructions
> probing code,
> - if an A32 instruction decode it and handle using the new code, moved from
> 32 bit arm kernel tree.

how this connects to the change in prepare_uretprobe(),

> --- a/kernel/events/uprobes.c
> +++ b/kernel/events/uprobes.c
> @@ -1566,6 +1566,9 @@ static void prepare_uretprobe(struct uprobe *uprobe, struct pt_regs *regs)
>  	unsigned long orig_ret_vaddr, trampoline_vaddr;
>  	bool chained;
>
> +	if (!current->mm)
> +		return;
> +

?

and how it is possible to hit ->mm == NULL here?

Oleg.

  reply	other threads:[~2018-01-24 16:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20180124123450eucas1p23a79f56cd4a65c790468cfc2f3e1339b@eucas1p2.samsung.com>
2018-01-24 12:34 ` [PATCH 0/7] arm64: uprobes - ARM32 instruction probing Maciej Slodczyk
2018-01-24 12:34   ` [PATCH 1/7] arm64: move arm uprobes code to be reused by arm64 Maciej Slodczyk
2018-01-24 12:34   ` [PATCH 2/7] arm64: uprobes - fix checkpatch.pl issues Maciej Slodczyk
2018-01-24 12:34   ` [PATCH 3/7] arm64: introduce get_swbp_insn() instead of static assignment Maciej Slodczyk
2018-01-24 12:34   ` [PATCH 4/7] arm64: change arm64 probes handler prototype Maciej Slodczyk
2018-01-24 12:34   ` [PATCH 5/7] arm64: make arm uprobes code reusable by arm64 Maciej Slodczyk
2018-01-24 12:34   ` [PATCH 6/7] arm64: change arm_probe_decode_insn() function name Maciej Slodczyk
2018-01-24 12:34   ` [PATCH 7/7] arm64: uprobes - ARM32 instruction probing Maciej Slodczyk
2018-01-24 16:13     ` Oleg Nesterov [this message]
2018-01-25 10:42       ` Maciej Slodczyk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180124161338.GA23561@redhat.com \
    --to=oleg@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.