All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@free-electrons.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/8] spl: nand: sunxi: Fix second case of modulo by zero error
Date: Wed, 24 Jan 2018 23:32:34 +0100	[thread overview]
Message-ID: <20180124233234.3a7650ba@xps13> (raw)
In-Reply-To: <20180124074731.7olf475c2d7ne7co@flea.lan>

Hi Maxime,

On Wed, 24 Jan 2018 08:47:31 +0100
Maxime Ripard <maxime.ripard@free-electrons.com> wrote:

> On Wed, Jan 24, 2018 at 01:44:48AM +0100, Miquel Raynal wrote:
> > In the nand_read_buffer() step, the seed is calculated by doing a modulo
> > by conf->nseeds which is always zero when not using the randomizer (most
> > of SLC NANDs).
> > 
> > This situation turns out to lead to a run time freeze.
> > 
> > Derive this seed only when the randomizer is enabled (and conf->nseeds
> > logically not zero).  
> 
> Mentionning the first occurence of that issue in your commit log would
> be great, especially since the situation depends on configuration
> options.

Absolutely, I added a reference in the commit message to:
ea3f750c73e3 ("nand: sunxi: Fix modulo by zero error")

Thanks,
Miquèl

  reply	other threads:[~2018-01-24 22:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24  0:44 [U-Boot] [PATCH 0/8] Bring NAND support to Nintendo NES Classic Miquel Raynal
2018-01-24  0:44 ` [U-Boot] [PATCH 1/8] mtd: nand: sunxi: Fix strength minimum value Miquel Raynal
2018-01-24  7:46   ` Maxime Ripard
2018-01-24 22:21     ` Miquel Raynal
2018-01-24  7:57   ` Boris Brezillon
2018-01-24 22:19     ` Miquel Raynal
2018-01-24  0:44 ` [U-Boot] [PATCH 2/8] spl: nand: sunxi: Fix second case of modulo by zero error Miquel Raynal
2018-01-24  7:47   ` Maxime Ripard
2018-01-24 22:32     ` Miquel Raynal [this message]
2018-01-24  0:44 ` [U-Boot] [PATCH 3/8] sunxi: Allow SPL to be compiled for sun8i platforms Miquel Raynal
2018-01-24  7:49   ` Maxime Ripard
2018-01-24 22:37     ` Miquel Raynal
2018-01-24  0:44 ` [U-Boot] [PATCH 4/8] spl: nand: sunxi: Enhancements and cleaning Miquel Raynal
2018-01-24  7:56   ` Maxime Ripard
2018-01-25 23:34     ` Miquel Raynal
2018-01-24  8:06   ` Boris Brezillon
2018-01-25 23:37     ` Miquel Raynal
2018-01-24  0:44 ` [U-Boot] [PATCH 5/8] spl: nand: sunxi: use PIO instead of DMA Miquel Raynal
2018-01-24  8:06   ` Maxime Ripard
2018-01-24  8:26     ` Boris Brezillon
2018-01-24  8:39       ` Maxime Ripard
2018-01-25 23:58     ` Miquel Raynal
2018-01-24  8:16   ` Boris Brezillon
2018-01-26  0:09     ` Miquel Raynal
2018-01-24  0:44 ` [U-Boot] [PATCH 6/8] configs: Add NAND support for NES Classic Miquel Raynal
2018-01-24  8:10   ` Maxime Ripard
2018-01-24  0:44 ` [U-Boot] [PATCH 7/8] sunxi: dts: Add NAND node to sun8i DTSI Miquel Raynal
2018-01-24  8:16   ` Maxime Ripard
2018-01-24  0:44 ` [U-Boot] [PATCH 8/8] sunxi: dts: Enable NAND on NES classic Miquel Raynal
2018-01-24  8:18   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180124233234.3a7650ba@xps13 \
    --to=miquel.raynal@free-electrons.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.