From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: jasowang@redhat.com, linux-kernel@vger.kernel.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] vhost: use mutex_lock_nested() in vhost_dev_lock_vqs()
Date: Wed, 24 Jan 2018 23:46:19 +0200 [thread overview]
Message-ID: <20180124234511-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20180124.163830.2180124252515802160.davem@davemloft.net>
On Wed, Jan 24, 2018 at 04:38:30PM -0500, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Tue, 23 Jan 2018 17:27:25 +0800
>
> > We used to call mutex_lock() in vhost_dev_lock_vqs() which tries to
> > hold mutexes of all virtqueues. This may confuse lockdep to report a
> > possible deadlock because of trying to hold locks belong to same
> > class. Switch to use mutex_lock_nested() to avoid false positive.
> >
> > Fixes: 6b1e6cc7855b0 ("vhost: new device IOTLB API")
> > Reported-by: syzbot+dbb7c1161485e61b0241@syzkaller.appspotmail.com
> > Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> Michael, I see you ACK'd this, meaning that you're OK with these two
> fixes going via my net tree?
>
> Thanks.
Yes - this seems to be what Jason wanted (judging by the net
tag in the subject) and I'm fine with it.
Thanks a lot.
--
MST
next prev parent reply other threads:[~2018-01-24 21:46 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-23 9:27 [PATCH net 1/2] vhost: use mutex_lock_nested() in vhost_dev_lock_vqs() Jason Wang
2018-01-23 9:27 ` Jason Wang
2018-01-23 9:27 ` [PATCH net 2/2] vhost: do not try to access device IOTLB when not initialized Jason Wang
2018-01-23 9:27 ` Jason Wang
2018-01-23 15:58 ` Michael S. Tsirkin
2018-01-23 15:58 ` Michael S. Tsirkin
2018-01-23 15:57 ` [PATCH net 1/2] vhost: use mutex_lock_nested() in vhost_dev_lock_vqs() Michael S. Tsirkin
2018-01-23 15:57 ` Michael S. Tsirkin
2018-01-24 21:38 ` David Miller
2018-01-24 21:38 ` David Miller
2018-01-24 21:46 ` Michael S. Tsirkin
2018-01-24 21:46 ` Michael S. Tsirkin [this message]
2018-01-24 21:55 ` David Miller
2018-01-24 21:55 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180124234511-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.