All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC PATCH] Allow providing default environment from file
Date: Thu, 25 Jan 2018 11:26:19 +0100	[thread overview]
Message-ID: <20180125112619.020e93cb@jawa> (raw)
In-Reply-To: <02e89a9e-bcd1-480c-ac9e-4c383789cf60@prevas.dk>

Hi Rasmus,

> On 2018-01-25 10:30, Lukasz Majewski wrote:
> > Hi Rasmus,
> >   
> >> It is sometimes useful to be able to define the entire default
> >> environment in an external file.  
> > 
> > There is already available script for extracting the environment.
> > 
> > Please look into:
> > ./scripts/get_default_envs.sh
> > 
> > Maybe you can reuse it in this patch?  
> 
> I'm sorry, but I don't see what I could use that for. It seems to do
> the opposite of what I want, 

Sorry. I have had misunderstood the patch description.

> namely extract the default environment
> and store it in a plain-text file. I want to provide a plain-text
> file to define the default environment.

Ok. Then your patch seems perfectly valid.

> 
> It's quite likely that that script can be useful for generating a
> sketch for the external file (i.e., build a U-boot as "usual" with
> default environment built from various config options etc. etc., then
> hand-edit that file to remove redundant stuff and add the things one
> needs). The thing is, having the default environment in an external
> file makes it much easier to put it under version control than having
> to maintain a branch inside the U-boot repo just to tweak
> CONFIG_EXTRA_ENV_SETTINGS.
> 
> Rasmus



Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180125/1f279520/attachment.sig>

  reply	other threads:[~2018-01-25 10:26 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24  9:55 [U-Boot] [RFC PATCH] Allow providing default environment from file Rasmus Villemoes
2018-01-25  9:30 ` Lukasz Majewski
2018-01-25 10:04   ` Rasmus Villemoes
2018-01-25 10:26     ` Lukasz Majewski [this message]
2018-01-26 13:22 ` Sean Nyekjaer
2018-02-02 20:15 ` Rasmus Villemoes
2018-03-19  7:17   ` Sean Nyekjær
2018-03-19 13:30 ` Tom Rini
2018-03-20 10:38 ` [U-Boot] [PATCH v2] " Rasmus Villemoes
2018-03-20 14:20   ` Lukasz Majewski
2018-03-20 14:47     ` Rasmus Villemoes
2018-04-04  8:40       ` Rasmus Villemoes
2018-04-07 13:25   ` [U-Boot] [U-Boot, " Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125112619.020e93cb@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.