All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Shields <simon@lineageos.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Andi Shyti <andi.shyti@samsung.com>,
	Rob Herring <robh@kernel.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] MMS114 touchscreen patches
Date: Fri, 26 Jan 2018 00:01:59 +1100	[thread overview]
Message-ID: <20180125130159.GA26726@lineageos.org> (raw)
In-Reply-To: <20180124193804.155654-1-dmitry.torokhov@gmail.com>

Hi Dmitry,

Thanks for the extra fixes!

On Wed, Jan 24, 2018 at 11:38:00AM -0800, Dmitry Torokhov wrote:
> Hi,
> 
> This is a combination of couple of my patches + Simons patches dropping
> support for platform data and adding support for mms152, slightly reworked.
> 
> Andi, because patches changed a bit I did not add your reviewed-by or
> tested-by, please take another look.
> 
> Thanks!
> 
> Dmitry Torokhov (2):
>   Input: mms114 - do not clobber interrupt trigger
>   Input: mms114 - mark as direct input device
> 
> Simon Shields (2):
>   Input: mms114 - drop platform data and use generic APIs
>   Input: mms114 - add support for mms152
> 
>  .../bindings/input/touchscreen/mms114.txt          |  35 ++--
>  drivers/input/touchscreen/mms114.c                 | 229 ++++++++++++---------
>  include/linux/platform_data/mms114.h               |  24 ---
>  3 files changed, 151 insertions(+), 137 deletions(-)
>  delete mode 100644 include/linux/platform_data/mms114.h
> 
> -- 
> Dmitry
> 

All looks good to me. Tested on MMS114 and MMS152.

Reviewed-by: Simon Shields <simon@lineageos.org>
Tested-by: Simon Shields <simon@lineageos.org>

Cheers,
Simon

      parent reply	other threads:[~2018-01-25 13:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-24 19:38 [PATCH 0/4] MMS114 touchscreen patches Dmitry Torokhov
2018-01-24 19:38 ` [PATCH 1/4] Input: mms114 - do not clobber interrupt trigger Dmitry Torokhov
2018-01-26  4:54   ` Andi Shyti
2018-01-24 19:38 ` [PATCH 2/4] Input: mms114 - mark as direct input device Dmitry Torokhov
2018-01-26  4:55   ` Andi Shyti
2018-01-24 19:38 ` [PATCH 3/4] Input: mms114 - drop platform data and use generic APIs Dmitry Torokhov
2018-01-26  5:06   ` Andi Shyti
2018-01-24 19:38 ` [PATCH 4/4] Input: mms114 - add support for mms152 Dmitry Torokhov
2018-01-24 20:04   ` Marcus Folkesson
2018-01-24 21:27     ` Dmitry Torokhov
2018-01-24 21:32     ` [PATCH 4/4 v2] " Dmitry Torokhov
2018-01-26  5:14       ` Andi Shyti
2018-01-26 19:25         ` Dmitry Torokhov
2018-01-25 13:01 ` Simon Shields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180125130159.GA26726@lineageos.org \
    --to=simon@lineageos.org \
    --cc=andi.shyti@samsung.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.