From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Cc: davem@davemloft.net, jiri@resnulli.us, dsahern@gmail.com,
daniel@iogearbox.net, john.fastabend@gmail.com,
netdev@vger.kernel.org, oss-drivers@netronome.com,
aring@mojatatu.com
Subject: Re: [PATCH net-next v2 00/12] net: sched: propagate extack to cls offloads on destroy and only with skip_sw
Date: Thu, 25 Jan 2018 13:11:57 -0200 [thread overview]
Message-ID: <20180125151157.GA12972@localhost.localdomain> (raw)
In-Reply-To: <20180124205424.6976-1-jakub.kicinski@netronome.com>
On Wed, Jan 24, 2018 at 12:54:12PM -0800, Jakub Kicinski wrote:
> Hi!
>
> This series some of Jiri's comments and the fact that today drivers
> may produce extack even if there is no skip_sw flag (meaning the
> driver failure is not really a problem), and warning messages will
> only confuse the users.
It's a fair point, but I think this is not the best solution. How will
the user then know why it failed to install in hw? Will have to
install a new rule, just with skip_sw, and hope that it fails with the
same reason?
Maybe it's better to let tc/ovs/etc only exhibit this information
under a certain log/debug level.
Marcelo
next prev parent reply other threads:[~2018-01-25 15:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 20:54 [PATCH net-next v2 00/12] net: sched: propagate extack to cls offloads on destroy and only with skip_sw Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 01/12] net: sched: propagate extack to cls->destroy callbacks Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 02/12] net: sched: prepare for reimplementation of tc_cls_common_offload_init() Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 03/12] cls_bpf: remove gen_flags from bpf_offload Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 04/12] cls_bpf: pass offload flags to tc_cls_common_offload_init() Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 05/12] cls_bpf: propagate extack to offload delete callback Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 06/12] cls_matchall: pass offload flags to tc_cls_common_offload_init() Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 07/12] cls_matchall: propagate extack to delete callback Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 08/12] cls_flower: pass offload flags to tc_cls_common_offload_init() Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 09/12] cls_flower: propagate extack to delete callback Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 10/12] cls_u32: pass offload flags to tc_cls_common_offload_init() Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 11/12] cls_u32: propagate extack to delete callback Jakub Kicinski
2018-01-24 20:54 ` [PATCH net-next v2 12/12] net: sched: remove tc_cls_common_offload_init_deprecated() Jakub Kicinski
2018-01-24 21:03 ` [PATCH net-next v2 00/12] net: sched: propagate extack to cls offloads on destroy and only with skip_sw David Miller
2018-01-24 21:04 ` Jiri Pirko
2018-01-24 21:07 ` David Ahern
2018-01-24 21:15 ` Jiri Pirko
2018-01-24 21:49 ` Jakub Kicinski
2018-01-25 15:11 ` Marcelo Ricardo Leitner [this message]
2018-01-25 22:57 ` Jakub Kicinski
2018-01-28 22:39 ` Marcelo Ricardo Leitner
2018-01-29 23:36 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125151157.GA12972@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=aring@mojatatu.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@netronome.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.