From: Tejun Heo <tj@kernel.org>
To: Jia-Ju Bai <baijiaju1990@gmail.com>
Cc: b.zolnierkie@samsung.com, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ata: pata_it821x: Replace mdelay with usleep_range in it821x_firmware_command
Date: Thu, 25 Jan 2018 07:31:15 -0800 [thread overview]
Message-ID: <20180125153115.GF17457@devbig577.frc2.facebook.com> (raw)
In-Reply-To: <1516876379-12834-1-git-send-email-baijiaju1990@gmail.com>
On Thu, Jan 25, 2018 at 06:32:59PM +0800, Jia-Ju Bai wrote:
> After checking all possible call chains to it821x_firmware_command here,
> my tool finds that it821x_firmware_command
> is never called in atomic context,
> namely never in an interrupt handler or holding a spinlock.
> And it821x_firmware_command calls kmalloc(GFP_KERNEL),
> so it proves again that it821x_firmware_command
> can call functions which can sleep.
> Thus mdelay can be replaced with usleep_range to avoid busy wait.
>
> This is found by a static analysis tool named DCNS written by myself.
>
> Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Applied to libata/for-4.16.
Thanks.
--
tejun
prev parent reply other threads:[~2018-01-25 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 10:32 [PATCH] ata: pata_it821x: Replace mdelay with usleep_range in it821x_firmware_command Jia-Ju Bai
2018-01-25 15:31 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125153115.GF17457@devbig577.frc2.facebook.com \
--to=tj@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=baijiaju1990@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.