From: Ido Schimmel <idosch@idosch.org>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down
Date: Thu, 25 Jan 2018 17:35:35 +0200 [thread overview]
Message-ID: <20180125153535.GA1453@splinter.mtl.com> (raw)
In-Reply-To: <20180125034529.9987-1-dsahern@gmail.com>
On Wed, Jan 24, 2018 at 07:45:29PM -0800, David Ahern wrote:
> IPv6 allows routes to be installed when the device is not up (admin up).
> Worse, it does not mark it as LINKDOWN. IPv4 does not allow it and really
> there is no reason for IPv6 to allow it, so check the flags and deny if
> device is admin down.
>
> Signed-off-by: David Ahern <dsahern@gmail.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Thanks!
next prev parent reply other threads:[~2018-01-25 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-25 3:45 [PATCH v3 net-next] net/ipv6: Do not allow route add with a device that is down David Ahern
2018-01-25 15:35 ` Ido Schimmel [this message]
2018-01-25 15:53 ` Roopa Prabhu
2018-01-25 21:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125153535.GA1453@splinter.mtl.com \
--to=idosch@idosch.org \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.