From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [Patch v6 0/7] KVM: Guest page hinting Date: Thu, 25 Jan 2018 19:28:50 +0200 Message-ID: <20180125192731-mutt-send-email-mst@kernel.org> References: <20171201173136.849-1-nilal@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: kvm@vger.kernel.org, pbonzini@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, yang.zhang.wz@gmail.com, riel@redhat.com, david@redhat.com, dodgen@google.com, konrad.wilk@oracle.com To: nilal@redhat.com Return-path: Received: from mx1.redhat.com ([209.132.183.28]:33404 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbeAYR3F (ORCPT ); Thu, 25 Jan 2018 12:29:05 -0500 Content-Disposition: inline In-Reply-To: <20171201173136.849-1-nilal@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On Fri, Dec 01, 2017 at 12:31:29PM -0500, nilal@redhat.com wrote: > Changelog in v6: > -Moved CONFIG_KVM_FREE_PAGE_HINTING from virt/kvm/Kconfig to arch/x86/kvm/Kconfig in order to resolve conflicts with other architectures: > *s390 has its own page hinting functionality > *powerpc has its own arch_free_page implementation > -Fixed the typo in virtio_balloon structure which caused compilation issues when guest page hinting was disabled > -Separated init_vqs implementation with and without hinting_vq enablement based on the CONFIG_KVM_FREE_PAGE_HINTING ifdef > > Virtio interface changes are picked up from Wei's patch-set for Virtio-balloon enhancement[3]. "Wei, How would you like me to credit you in the final patch?") So the main point missing in all this is any kind of performance numbers: what kind of gain do you see with these patches and for which workloads? What kind of overhead and for which workloads? -- MST