From: Darren Hart <dvhart@infradead.org>
To: Vadim Pasternak <vadimp@mellanox.com>
Cc: andy.shevchenko@gmail.com, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, jiri@resnulli.us
Subject: Re: [patch v11 09/12] platform/x86: mlx-platform: Simplify IO access to regmap context
Date: Thu, 25 Jan 2018 14:13:32 -0800 [thread overview]
Message-ID: <20180125221332.GC24122@fury> (raw)
In-Reply-To: <1516826098-125036-1-git-send-email-vadimp@mellanox.com>
On Wed, Jan 24, 2018 at 08:34:55PM +0000, Vadim Pasternak wrote:
> Get rid of struct mlxplat_mlxcpld_regmap_context, which contains only the
> field with base address. Instead obtain base memory address by
> devm_ioport_map to local variable and pass it to devm_regmap_init.
>
> Modify mlxplat_mlxcpld_reg_read/write to directly use pointer to context
> for IO operations.
>
> Add missed description of pdev_hotplug for struct mlxplat_priv.
Separate patch. Keep in mind that if there is a bug, and a patch is reverted -
do you want it all reverted together? In this case, the comment is totally
unrelated to this change. I've made this change.
--
Darren Hart
VMware Open Source Technology Center
prev parent reply other threads:[~2018-01-25 22:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 20:34 [patch v11 09/12] platform/x86: mlx-platform: Simplify IO access to regmap context Vadim Pasternak
2018-01-24 20:34 ` [patch v11 10/12] platform/x86: mlx-platform: Extend register map configuration with IO access verification callbacks Vadim Pasternak
2018-01-25 22:16 ` Darren Hart
2018-01-24 20:34 ` [patch v11 11/12] platform/mellanox: mlxreg-hotplug: Add check for negative adapter number value Vadim Pasternak
2018-01-25 22:16 ` Darren Hart
2018-01-24 20:34 ` [patch v11 12/12] platform/mellanox: Add validation of return code of hotplug device creation routine Vadim Pasternak
2018-01-25 22:28 ` Darren Hart
2018-01-25 22:13 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180125221332.GC24122@fury \
--to=dvhart@infradead.org \
--cc=andy.shevchenko@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiri@resnulli.us \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=vadimp@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.