From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751667AbeAYWax (ORCPT ); Thu, 25 Jan 2018 17:30:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37308 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751228AbeAYWav (ORCPT ); Thu, 25 Jan 2018 17:30:51 -0500 Date: Thu, 25 Jan 2018 23:30:43 +0100 From: Jiri Benc To: Nicolas Dichtel Cc: Christian Brauner , netdev@vger.kernel.org, ebiederm@xmission.com, davem@davemloft.net, dsahern@gmail.com, fw@strlen.de, daniel@iogearbox.net, lucien.xin@gmail.com, mschiffer@universe-factory.net, jakub.kicinski@netronome.com, vyasevich@gmail.com, linux-kernel@vger.kernel.org, w.bumiller@proxmox.com, Christian Brauner Subject: Re: [PATCH net-next 0/3 V1] rtnetlink: enable IFLA_IF_NETNSID for RTM_{DEL,SET}LINK Message-ID: <20180125233043.66ff08c2@redhat.com> In-Reply-To: References: <20180124142634.17766-1-christian.brauner@ubuntu.com> <20180124173515.5ae2bc05@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 25 Jan 2018 15:20:59 +0100, Nicolas Dichtel wrote: > Hmm, I don't agree. For me, it would be the correct answer. If user has a socket > in ns_a and targets a RTM_GETLINK in ns_b, the answer he gets should be like if > it was done in ns_b. But that information would be useless for the caller. Why return a value that has no meaning for the caller and can not be used? More so when the kernel is aware of what the correct meaningful value is? > This is already the case with messages received with NETLINK_LISTEN_ALL_NSID, > there is no reason to do something different. NETLINK_LISTEN_ALL_NSID is tough due to way it is implemented. But yes, it should translate the netnsids to be valid in the socket's netns. That's the only sane way for the listener. Jiri