From: kbuild test robot <fengguang.wu@intel.com>
To: Edward Cree <ecree@solarflare.com>
Cc: kbuild-all@01.org, netdev@vger.kernel.org,
Solarflare linux maintainers <linux-net-drivers@solarflare.com>,
Bert Kenward <bkenward@solarflare.com>,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static
Date: Fri, 26 Jan 2018 09:03:04 +0800 [thread overview]
Message-ID: <20180126010304.GA87465@cairo> (raw)
In-Reply-To: <201801260928.N1021lrX%fengguang.wu@intel.com>
Fixes: 2935e3c38228 ("sfc: on 8000 series use TX queues for TX timestamps")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
efx.c | 2 +-
ptp.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
index 456866b0..16757cf 100644
--- a/drivers/net/ethernet/sfc/efx.c
+++ b/drivers/net/ethernet/sfc/efx.c
@@ -896,7 +896,7 @@ void efx_schedule_slow_fill(struct efx_rx_queue *rx_queue)
mod_timer(&rx_queue->slow_fill, jiffies + msecs_to_jiffies(100));
}
-bool efx_default_channel_want_txqs(struct efx_channel *channel)
+static bool efx_default_channel_want_txqs(struct efx_channel *channel)
{
return channel->channel - channel->efx->tx_channel_offset <
channel->efx->n_tx_channels;
diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
index 433d29d..3e2c5b1 100644
--- a/drivers/net/ethernet/sfc/ptp.c
+++ b/drivers/net/ethernet/sfc/ptp.c
@@ -366,7 +366,7 @@ bool efx_ptp_use_mac_tx_timestamps(struct efx_nic *efx)
/* PTP 'extra' channel is still a traffic channel, but we only create TX queues
* if PTP uses MAC TX timestamps, not if PTP uses the MC directly to transmit.
*/
-bool efx_ptp_want_txqs(struct efx_channel *channel)
+static bool efx_ptp_want_txqs(struct efx_channel *channel)
{
return efx_ptp_use_mac_tx_timestamps(channel->efx);
}
@@ -2146,7 +2146,7 @@ static int efx_phc_enable(struct ptp_clock_info *ptp,
return 0;
}
-const struct efx_channel_type efx_ptp_channel_type = {
+static const struct efx_channel_type efx_ptp_channel_type = {
.handle_no_channel = efx_ptp_handle_no_channel,
.pre_probe = efx_ptp_probe_channel,
.post_remove = efx_ptp_remove_channel,
next prev parent reply other threads:[~2018-01-26 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-26 1:03 [net-next:master 1913/1931] drivers/net/ethernet/sfc/efx.c:899:6: sparse: symbol 'efx_default_channel_want_txqs' was not declared. Should it be static? kbuild test robot
2018-01-26 1:03 ` kbuild test robot [this message]
2018-01-26 15:13 ` [RFC PATCH net-next] sfc: efx_default_channel_want_txqs() can be static Edward Cree
2018-01-26 16:13 ` David Miller
2018-01-26 17:00 ` [PATCH net-next] sfc: mark some unexported symbols as static Edward Cree
2018-01-29 2:59 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126010304.GA87465@cairo \
--to=fengguang.wu@intel.com \
--cc=bkenward@solarflare.com \
--cc=ecree@solarflare.com \
--cc=kbuild-all@01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.