All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: 禹舟键 <ufo19890607@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	mingo@redhat.com,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, David Ahern <dsahern@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Milian Wolff <milian.wolff@kdab.com>,
	Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>,
	Wind Yu <yuzhoujian@didichuxing.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Wang Nan <wangnan0@huawei.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	acme@redhat.com
Subject: Re: [PATCH v2 2/2] perf stat: Add support to print counts after a period of time
Date: Fri, 26 Jan 2018 08:51:04 +0100	[thread overview]
Message-ID: <20180126075104.GA4754@krava> (raw)
In-Reply-To: <CAHCio2hg-C55Ue=bUzu-6sYyGXaCw916AAZ7CzJFW-x1dyWmyw@mail.gmail.com>

On Fri, Jan 26, 2018 at 09:59:02AM +0800, 禹舟键 wrote:
> 2018-01-25 20:27 GMT+08:00 Jiri Olsa <jolsa@redhat.com>:
> 
> > On Thu, Jan 25, 2018 at 10:10:04AM +0100, ufo19890607 wrote:
> >
> > SNIP
> >
> > >  --metric-only::
> > >  Only print computed metrics. Print them in a single line.
> > > diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> > > index 406f546ad74c..427f06dc35cc 100644
> > > --- a/tools/perf/builtin-stat.c
> > > +++ b/tools/perf/builtin-stat.c
> > > @@ -573,6 +573,7 @@ static int __run_perf_stat(int argc, const char
> > **argv)
> > >  {
> > >       int interval = stat_config.interval;
> > >       int times = stat_config.times;
> > > +     int time = stat_config.time;
> > >       char msg[BUFSIZ];
> > >       unsigned long long t0, t1;
> > >       struct perf_evsel *counter;
> > > @@ -586,6 +587,9 @@ static int __run_perf_stat(int argc, const char
> > **argv)
> > >       if (interval) {
> > >               ts.tv_sec  = interval / USEC_PER_MSEC;
> > >               ts.tv_nsec = (interval % USEC_PER_MSEC) * NSEC_PER_MSEC;
> > > +     } else if (time) {
> > > +             ts.tv_sec  = time / USEC_PER_MSEC;
> > > +             ts.tv_nsec = (time % USEC_PER_MSEC) * NSEC_PER_MSEC;
> >
> > I like the idea.. it won't work with -I option, but let's
> > keep it like that until someone needs it ;-)
> >
> >
> Hi Jirka
> 
> What do you mean by this sentence???

that I'm ok with the patch with small fixes I mentioned

jirka

      parent reply	other threads:[~2018-01-26  7:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25  9:10 [PATCH v2 0/2] perf stat: Add interval-count and time support ufo19890607
2018-01-25  9:10 ` [PATCH v2 1/2] perf stat: Add support to print counts for fixed times ufo19890607
2018-01-25  9:10 ` [PATCH v2 2/2] perf stat: Add support to print counts after a period of time ufo19890607
2018-01-25 12:27   ` Jiri Olsa
     [not found]     ` <CAHCio2hg-C55Ue=bUzu-6sYyGXaCw916AAZ7CzJFW-x1dyWmyw@mail.gmail.com>
2018-01-26  7:51       ` Jiri Olsa [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180126075104.GA4754@krava \
    --to=jolsa@redhat.com \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=arnaldo.melo@gmail.com \
    --cc=dsahern@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=milian.wolff@kdab.com \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=ufo19890607@gmail.com \
    --cc=wangnan0@huawei.com \
    --cc=yuzhoujian@didichuxing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.