From: Matt Fleming <matt@codeblueprint.co.uk>
To: Sai Praneeth Prakhya <sai.praneeth.prakhya@intel.com>
Cc: linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, "Lee,
Chun-Yi" <jlee@suse.com>, Borislav Petkov <bp@alien8.de>,
Tony Luck <tony.luck@intel.com>,
Andy Lutomirski <luto@kernel.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Ricardo Neri <ricardo.neri@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Ravi Shankar <ravi.v.shankar@intel.com>
Subject: Re: [PATCH V4 0/3] Use mm_struct and switch_mm() instead of manually
Date: Fri, 26 Jan 2018 21:16:43 +0000 [thread overview]
Message-ID: <20180126211643.GB6520@codeblueprint.co.uk> (raw)
In-Reply-To: <1516309264-23926-1-git-send-email-sai.praneeth.prakhya@intel.com>
On Thu, 18 Jan, at 01:01:04PM, Sai Praneeth Prakhya wrote:
> From: Sai Praneeth <sai.praneeth.prakhya@intel.com>
>
> Presently, in x86, to invoke any efi function like
> efi_set_virtual_address_map() or any efi_runtime_service() the code path
> typically involves read_cr3() (save previous pgd), write_cr3()
> (write efi_pgd) and calling efi function. Likewise after returning from
> efi function the code path typically involves read_cr3() (save efi_pgd),
> write_cr3() (write previous pgd). We do this couple of times in efi
> subsystem of Linux kernel, instead we can use helper function
> efi_switch_mm() to do this. This improves readability and maintainability.
> Also, instead of maintaining a separate struct "efi_scratch" to store/restore
> efi_pgd, we can use mm_struct to do this.
FWIW this series looks OK to me.
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
next prev parent reply other threads:[~2018-01-26 21:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-18 21:01 [PATCH V4 0/3] Use mm_struct and switch_mm() instead of manually Sai Praneeth Prakhya
2018-01-18 21:01 ` Sai Praneeth Prakhya
2018-01-26 21:16 ` Matt Fleming [this message]
[not found] ` <20180126211643.GB6520-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2018-01-29 10:51 ` Ard Biesheuvel
2018-01-29 10:51 ` Ard Biesheuvel
2018-03-03 20:40 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180126211643.GB6520@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=bp@alien8.de \
--cc=jlee@suse.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mst@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=ricardo.neri@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.