From: "Ognjen Galić" <smclt30p@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dmitry Rozhkov <dmitry.rozhkov@linux.intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>
Subject: Re: [2/4] ACPI / battery: reorder headers alphabetically
Date: Sat, 27 Jan 2018 08:29:40 +0100 [thread overview]
Message-ID: <20180127072940.GA839@thinkpad> (raw)
In-Reply-To: <CAJZ5v0hKQfRDsg_R_ZEEJrRnf8uFi5cUZ_brSME2R086zkhm7g@mail.gmail.com>
On Mon, Jan 15, 2018 at 01:06:47AM +0100, Rafael J. Wysocki wrote:
> On Mon, Jan 15, 2018 at 12:50 AM, Ognjen Galić <smclt30p@gmail.com> wrote:
> > On Mon, Jan 15, 2018 at 12:40:13AM +0100, Rafael J. Wysocki wrote:
> >> On Sun, Jan 14, 2018 at 12:55 PM, Andy Shevchenko
> >> <andriy.shevchenko@linux.intel.com> wrote:
> >> > On Sat, 2018-01-13 at 12:53 +0100, Ognjen Galić wrote:
> >> >> > -#include <linux/kernel.h>
> >> >> > -#include <linux/module.h>
> >> >> > -#include <linux/types.h>
> >> >> > -#include <linux/jiffies.h>
> >> >> > #include <linux/async.h>
> >> >> > -#include <linux/dmi.h>
> >> >> > #include <linux/delay.h>
> >> >> > +#include <linux/dmi.h>
> >> >> > +#include <linux/jiffies.h>
> >> >> > +#include <linux/kernel.h>
> >> >> > +#include <linux/module.h>
> >> >> > #include <linux/slab.h>
> >> >> > #include <linux/suspend.h>
> >> >> > -#include <asm/unaligned.h>
> >> >> > +#include <linux/types.h>
> >> >>
> >> >> These changes completely break my patch:
> >> >> https://patchwork.kernel.org/patch/10142157/
> >> >>
> >> >> Can we please postpone this patch until I hear back from Rafael
> >> >> about my series, as my series does some of the things this patch
> >> >> series does (like defining pr_fmt to shorten log prints) and this
> >> >> is a much smaller changeset and would require small changes on
> >> >> conflicts compared to my series?
> >> >
> >> > Definitely on both series we need to hear from Rafael.
> >>
> >> Right, I still need to convince myself that the Ognjen's series
> >> actually works in all cases which I'm not quite sure about ATM.
> >
> > What edge cases are you concerned about?
>
> Initialization ordering, basically.
>
> It appears to work only under specific assumptions that are not
> guaranteed to be satisfied universally, but I need to walk though it
> again to check that.
Well, any updates? It's been a while.
next prev parent reply other threads:[~2018-01-27 7:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-13 11:53 [2/4] ACPI / battery: reorder headers alphabetically Ognjen Galić
2018-01-14 11:55 ` Andy Shevchenko
2018-01-14 23:40 ` Rafael J. Wysocki
2018-01-14 23:50 ` Ognjen Galić
2018-01-15 0:06 ` Rafael J. Wysocki
2018-01-15 0:10 ` Ognjen Galić
2018-01-27 7:29 ` Ognjen Galić [this message]
2018-01-29 3:05 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180127072940.GA839@thinkpad \
--to=smclt30p@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.rozhkov@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.