All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] ltp-testsuite: drop redundant arch dependency entries
Date: Sat, 27 Jan 2018 23:07:07 +0100	[thread overview]
Message-ID: <20180127230707.450300b0@windsurf> (raw)
In-Reply-To: <2f61c63d53f8ba4ea0b65942b57f67a156fbf778.1516964598.git.baruch@tkos.co.il>

Hello,

On Fri, 26 Jan 2018 13:03:18 +0200, Baruch Siach wrote:
> BR2_TOOLCHAIN_HAS_SYNC_4 is enabled for all these architectures except
> arc. There is no need to list them explicitly.
> 
> Cc: Romain Naour <romain.naour@gmail.com>
> Cc: Petr Vorel <petr.vorel@gmail.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
>  package/ltp-testsuite/Config.in | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/package/ltp-testsuite/Config.in b/package/ltp-testsuite/Config.in
> index 4c00e40f330e..711c859e6caf 100644
> --- a/package/ltp-testsuite/Config.in
> +++ b/package/ltp-testsuite/Config.in
> @@ -5,11 +5,6 @@ config BR2_PACKAGE_LTP_TESTSUITE_ARCH_SUPPORTS
>  	# provided in ltp-testsuite
>  	default y if BR2_TOOLCHAIN_HAS_SYNC_4
>  	default y if BR2_arc
> -	default y if BR2_i386
> -	default y if BR2_powerpc
> -	default y if BR2_powepc64
> -	default y if BR2_powerpc64le
> -	default y if BR2_x86_64

Is this really a correct patch ? It's not because
BR2_TOOLCHAIN_HAS_SYNC_4 already covers
i386/powerpc/powerpc64/powerpc64le/x86_64 that it makes sense to use
BR2_TOOLCHAIN_HAS_SYNC_4 instead.

What if an architecture gets added to BR2_TOOLCHAIN_HAS_SYNC_4, but
isn't supported by ltp-testsuite ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  parent reply	other threads:[~2018-01-27 22:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-26 11:03 [Buildroot] [PATCH 1/2] ltp-testsuite: disable numa tests Baruch Siach
2018-01-26 11:03 ` [Buildroot] [PATCH 2/2] ltp-testsuite: drop redundant arch dependency entries Baruch Siach
2018-01-26 11:35   ` Petr Vorel
2018-01-27 10:17   ` Peter Korsgaard
2018-01-27 22:07   ` Thomas Petazzoni [this message]
2018-01-28  3:24     ` Baruch Siach
2018-01-26 11:17 ` [Buildroot] [PATCH 1/2] ltp-testsuite: disable numa tests Petr Vorel
2018-01-26 13:37   ` Baruch Siach
2018-01-26 14:08     ` Baruch Siach
2018-01-26 14:55       ` Petr Vorel
2018-01-26 15:14     ` Petr Vorel
2018-01-27 10:18 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180127230707.450300b0@windsurf \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.