Re: [PATCH 0/4] Fix fonts in figures

["Paul E. McKenney" <paulmck@linux.vnet.ibm.com>]

On Sat, Jan 27, 2018 at 06:51:07PM +0900, Akira Yokosawa wrote:
> >From 3fd97ea1bffc46d5ea2946397d3fa5debf74579e Mon Sep 17 00:00:00 2001
> From: Akira Yokosawa <akiyks@gmail.com>
> Date: Sat, 27 Jan 2018 16:30:20 +0900
> Subject: [PATCH 0/4] Fix fonts in figures
> 
> Hi Paul,
> 
> This patch set is the result of my investigation of improper font
> rendering in figures on Fedora 27.  In the end, I found several
> font-related issues which also affected the results on other
> platforms.
> 
> The cause of the font problem on Fedora 27 is the introduction
> of URW++ v2 font family.  It is not compatible with fixfonts.sh's
> font conversion.
> 
> Another problem on Fedora 27 is that ghostscript 9.22 does not work
> with a2ping script. I reported the issue to Red Hat Bugzilla [1].
> So far, it has not been resolved.  a2ping issue is not touched in
> this patch set.
> 
> [1]: https://bugzilla.redhat.com/show_bug.cgi?id=1530268
> 
> Patch #1 adds a font conversion script for .svg files. In some
> .svg files, non-free font names such as "Helvetica" and "Courier"
> are used. Also, a generic font name of "Sans" causes the result
> to depend on locale setting. Converting those names to URW font-
> family names can eliminate the ambiguity.
> It also adds a recipe to convert fonts in .eps files which are
> the origin of figures (mostly generated by gnuplot).
> 
> Patch #2 fixes fixfonts.sh to avoid unintended conversions.
> 
> Patch #3 fixes font names embedded in .eps files which look
> like the result of wrong conversion before they were committed.
> 
> Patch #4 adds conversion scripts for URW++ v2 font family.
> Which set of scripts to use is determined in Makefile according
> to the result of "fc-list" command.
> 
> These changes have been tested on Ubuntu Trusty, Ubuntu Xenial,
> Fedora 26, and Fedora 27 (with ghostscript downgraded to 9.20).
> 
> Differences in the resulting figures can be seen in Figures 9.1,
> 9.7, 9.8, 17.5, and 17.6.
> 
> You need to do "make neatfreak; make -j4" to ensure all the
> affected figures to be rebuilt.

They do look nicer.  Applied and pushed, thank you!!!

>          Thanks, Akira
> 
> NOTE 1: After KPTI was applied, ghostscript slowed down significantly
> on virtual guest machines (might as well on real machines).

Meltdown and Spectre do seem to exact a price in terms of performance,
don't they?  :-/

> NOTE 2: Before this change, full rebuild on Ubuntu Trusty with small
> RAM size (<2GB) sometimes ended up in DOS (thrashing). Now this
> symptom has disappeared.

Very good!  (Me, I have quite a bit more memory, but very good to
make it work for people on smaller systems.)

							Thanx, Paul

> --
> Akira Yokosawa (4):
>   Add fixsvgfonts.sh
>   Fix pattern order in fixfonts.sh
>   future: Fix embedded font name in .eps files
>   Makefile: Support URW++ v2 font family names
> 
>  Makefile                         | 38 +++++++++++++++++++++----
>  future/be-lb-n4-rf-all.eps       |  4 +--
>  future/be-lw-n4-rf-all.eps       |  4 +--
>  future/latencytrend.eps          |  4 +--
>  utilities/fixanepsfonts-urwps.sh | 27 ++++++++++++++++++
>  utilities/fixfonts-urwps.sh      | 61 ++++++++++++++++++++++++++++++++++++++++
>  utilities/fixfonts.sh            | 28 ++++++++++++++----
>  utilities/fixsvgfonts-urwps.sh   | 23 +++++++++++++++
>  utilities/fixsvgfonts.sh         | 15 ++++++++++
>  9 files changed, 187 insertions(+), 17 deletions(-)
>  create mode 100644 utilities/fixanepsfonts-urwps.sh
>  create mode 100644 utilities/fixfonts-urwps.sh
>  create mode 100644 utilities/fixsvgfonts-urwps.sh
>  create mode 100644 utilities/fixsvgfonts.sh
> 
> -- 
> 2.7.4
>