All of lore.kernel.org
 help / color / mirror / Atom feed
From: tomli@tomli.me
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [HELP] cryptomount is slow, what is the proper way to [PATCH] libgcrypt-grub?
Date: Sun, 28 Jan 2018 17:03:15 +0800	[thread overview]
Message-ID: <20180128090315.GA16153@x220> (raw)
In-Reply-To: <CAEaD8JM2x=hzJieEb=ps_SOsn=zGDhQnEQeZrhAFghpYM7sVrg@mail.gmail.com>

> In GRUB SSE registers are disabled. If you want to use SSE, you need to
> make sure you enable them and that they are disabled again before kernel
> handoff

Thanks for the tip.
 
>> I have no idea about how to integrate my changes. For example, how to link
>> .c and .S assembly together in the same GRUB module by changing import_gcry.py?
>> I can't understand. From some comments, modifications of libgcrypt itself
>> is not
>> allowed at all, and import_gcry.py should do all the additional fixups?

> Yes, just put your version of libgcrypt there and rerun ./autogen.sh

I've added a .S file for the additional assembly code to be link with
sha512.c, but apparently import_gcry.py doesn't know how to preprocess
this file:

    WARNING: unknown file sha512-sse2-x86.S
    gcry_sha512

I've read import_gcry.py but the preprocessing is pretty complicated.
What is the correct way to make my assembly code be recognized and
preprocessed as a grub module by the script?

Cheers,
Tom Li


      reply	other threads:[~2018-01-28  9:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-25 13:56 [HELP] cryptomount is slow, what is the proper way to [PATCH] libgcrypt-grub? tomli
2018-01-27  0:42 ` Vladimir 'phcoder' Serbinenko
2018-01-28  9:03   ` tomli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180128090315.GA16153@x220 \
    --to=tomli@tomli.me \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.