From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: Network Development <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
rds-devel@oss.oracle.com, santosh.shilimkar@oracle.com
Subject: Re: [PATCH net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case
Date: Sun, 28 Jan 2018 14:57:26 -0500 [thread overview]
Message-ID: <20180128195726.GD22885@oracle.com> (raw)
In-Reply-To: <CAF=yD-+FMXepBxoSuV-L4fYYb=bBE=gDT+vdKQFawpy5Pk4yCg@mail.gmail.com>
On (01/28/18 19:39), Willem de Bruijn wrote:
> > But the whole test program is rather simplistic, since it doesnt
> > actually verify the value of the cookies (hopefully me pending
:
> It might be nice to at least increment the variable on each
> successful send. The test is single threaded anyway. And
> then we can test that the returned values are in the defined
> range.
Yeah one thought that went through my head was that since
I now pick the cookes as consecutive numbers (1..N) anyway,
we could do a very simple-minded checksum on recv_completion
notification to check that the sum of all the cookie values
returned is actually N * (N+1)/2 - and flag errors/warnings
if it is not..
this would be a test enhancement I could do later.. first let
me try to avoid having all this complex timer-triggered code.
--Sowmini
next prev parent reply other threads:[~2018-01-28 19:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-24 11:45 [PATCH net-next 0/7] RDS zerocopy support Sowmini Varadhan
2018-01-24 11:45 ` [PATCH net-next 1/7] skbuff: export mm_[un]account_pinned_pages for other modules Sowmini Varadhan
2018-01-24 11:45 ` [PATCH net-next 2/7] rds: hold a sock ref from rds_message to the rds_sock Sowmini Varadhan
2018-01-25 14:44 ` Willem de Bruijn
2018-01-25 15:35 ` Sowmini Varadhan
2018-01-28 13:51 ` Willem de Bruijn
2018-01-28 16:18 ` Sowmini Varadhan
2018-01-28 18:54 ` Willem de Bruijn
2018-01-24 11:45 ` [PATCH net-next 3/7] sock: permit SO_ZEROCOPY on PF_RDS socket Sowmini Varadhan
2018-01-24 11:45 ` [PATCH net-next 4/7] rds: support for zcopy completion notification Sowmini Varadhan
2018-01-28 13:56 ` Willem de Bruijn
2018-01-28 16:15 ` Sowmini Varadhan
2018-01-28 18:46 ` Willem de Bruijn
2018-01-24 11:46 ` [PATCH net-next 5/7] rds: zerocopy Tx support Sowmini Varadhan
2018-01-28 13:57 ` Willem de Bruijn
2018-01-24 11:46 ` [PATCH net-next 6/7] selftests/net: add support for PF_RDS sockets Sowmini Varadhan
2018-01-28 13:58 ` Willem de Bruijn
2018-01-24 11:46 ` [PATCH net-next 7/7] selftests/net: add zerocopy support for PF_RDS test case Sowmini Varadhan
2018-01-28 14:00 ` Willem de Bruijn
2018-01-28 16:18 ` Sowmini Varadhan
2018-01-28 18:39 ` Willem de Bruijn
2018-01-28 19:57 ` Sowmini Varadhan [this message]
2018-01-25 16:41 ` [PATCH net-next 0/7] RDS zerocopy support Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180128195726.GD22885@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=santosh.shilimkar@oracle.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.