All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Chris Murphy <bugzilla@colorremedies.com>,
	intel-gfx@lists.freedesktop.org
Subject: Re: [Bug 104805] regression in 4.15 unable to reboot/poweroff, vgaswitcheroo doesn't work, RIP: 0010:i915_pci_probe+0x11/0x70 [i915]
Date: Sun, 28 Jan 2018 22:37:11 +0100	[thread overview]
Message-ID: <20180128213711.GA16470@wunner.de> (raw)
In-Reply-To: <bug-104805-53338-UTYydIcdyS@http.bugs.freedesktop.org/>

On Sat, Jan 27, 2018 at 10:42:45AM +0000, bugzilla-daemon@freedesktop.org wrote:
> https://bugs.freedesktop.org/show_bug.cgi?id=104805
> 
> --- Comment #6 from Chris Wilson <chris@chris-wilson.co.uk> ---
> Sigh. Revert then solve the bloat another way. I think we can move it to a
> seperate module and only load it during pci_probe. (That module can then play
> some tricks to construct driver_info using private commands to allow feature
> enabling.)

The following might work:  Set i915_pci_driver->id_table = NULL.
Then in i915_init(), after calling pci_register_driver(), iterate
over pciidlist[] and call pci_add_dynid() for each entry.  Finally,
call pci_free_dynids().

The problem is that after manually unbinding the driver via sysfs,
you can't bind it again.

Also, as soon as Intel introduces a discrete GPU (e.g. in a dock,
hotplugged via Thunderbolt), the whole idea falls apart.

How many bytes are we talking about here anyway?  I imagine it's less
than a page.  Honestly I think it's not worth the effort.

I'm wondering why noone else is seeing this crash, myself included.
Is the driver somehow unbound and rebound on Chris Murphy's machine?

@Chris Murphy: You may have noticed an 8 second delay on reboot with
4.15.  Before you waste time bisecting it:  A fix is already queued
for 4.16 and marked for stable:
https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git/commit/?id=493fb50e958c

Have a pleasant fin de weekend.

Lukas
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

       reply	other threads:[~2018-01-28 21:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-104805-53338@http.bugs.freedesktop.org/>
     [not found] ` <bug-104805-53338-UTYydIcdyS@http.bugs.freedesktop.org/>
2018-01-28 21:37   ` Lukas Wunner [this message]
2018-01-28 23:19     ` [Bug 104805] regression in 4.15 unable to reboot/poweroff, vgaswitcheroo doesn't work, RIP: 0010:i915_pci_probe+0x11/0x70 [i915] Chris Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180128213711.GA16470@wunner.de \
    --to=lukas@wunner.de \
    --cc=bugzilla@colorremedies.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.