From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v3 6/8] drm: Expose modes with aspect ratio, only if requested Date: Mon, 29 Jan 2018 20:58:24 +0200 Message-ID: <20180129185824.GV5453@intel.com> References: <1515738096-16892-1-git-send-email-ankit.k.nautiyal@intel.com> <1515738096-16892-7-git-send-email-ankit.k.nautiyal@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ACB76E61C for ; Mon, 29 Jan 2018 18:58:29 +0000 (UTC) Content-Disposition: inline In-Reply-To: <1515738096-16892-7-git-send-email-ankit.k.nautiyal@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Nautiyal, Ankit K" Cc: Jose Abreu , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKYW4gMTIsIDIwMTggYXQgMTE6NTE6MzRBTSArMDUzMCwgTmF1dGl5YWwsIEFua2l0 IEsgd3JvdGU6Cj4gRnJvbTogQW5raXQgTmF1dGl5YWwgPGFua2l0LmsubmF1dGl5YWxAaW50ZWwu Y29tPgo+IAo+IFdlIHBhcnNlIHRoZSBFRElEIGFuZCBhZGQgYWxsIHRoZSBtb2RlcyBpbiB0aGUg Y29ubmVjdG9yJ3MKPiBtb2RlbGlzdC4gVGhpcyBhZGRzIENFQSBtb2RlcyB3aXRoIGFzcGVjdCBy YXRpbyBpbmZvcm1hdGlvbgo+IHRvbywgcmVnYWRsZXNzIG9mIGlmIHVzZXIgc3BhY2UgcmVxdWVz dGVkIHRoaXMgaW5mb3JtYXRpb24gb3IKPiBub3QuCj4gCj4gVGhpcyBwYXRjaCBwcnVuZXMgdGhl IG1vZGVzIHdpdGggYXNwZWN0LXJhdGlvIGluZm9ybWF0aW9uLCBmcm9tCj4gYSBjb25uZWN0b3In cyBtb2RlbGlzdCwgaWYgdGhlIHVzZXItc3BhY2UgaGFzIG5vdCBzZXQgdGhlIGFzcGVjdAo+IHJh dGlvIERSTSBjbGllbnQgY2FwLgo+IAo+IENjOiBWaWxsZSBTeXJqYWxhIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPiBDYzogU2hhc2hhbmsgU2hhcm1hIDxzaGFzaGFuay5zaGFybWFA aW50ZWwuY29tPgo+IENjOiBKb3NlIEFicmV1IDxqb3NlLmFicmV1QHN5bm9wc3lzLmNvbT4KPiAK PiBTaWduZWQtb2ZmLWJ5OiBBbmtpdCBOYXV0aXlhbCA8YW5raXQuay5uYXV0aXlhbEBpbnRlbC5j b20+Cj4gCj4gVjM6IEFzIHN1Z2dlc3RlZCBieSBWaWxsZSwgbW9kaWZpZWQgdGhlIG1lY2hhbmlz bSBvZiBwcnVuaW5nIG9mCj4gbW9kZXMgd2l0aCBhc3BlY3QtcmF0aW8sIGlmIHRoZSBhc3BlY3Qt cmF0aW8gaXMgbm90IHN1cHBvcnRlZC4KPiBJbnN0ZWFkIG9mIHN0cmFpZ2h0IGF3YXkgcHJ1bmlu ZyBzdWNoIGEgbW9kZSwgdGhlIG1vZGUgaXMKPiByZXRhaW5lZCB3aXRoIGFzcGVjdC1yYXRpbyBi aXRzIHNldCB0byB6ZXJvLCBwcm92aWRlZCBpdCBpcwo+IHVuaXF1ZS4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYyB8IDMxICsrKysrKysrKysrKysrKysrKysrKysrKysr Ky0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDI3IGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0p Cj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fY29ubmVjdG9yLmMgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gaW5kZXggYjg1YTc3NC4uZDk2OGVjMyAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2Nvbm5lY3Rvci5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2RybV9jb25uZWN0b3IuYwo+IEBAIC0xNTAyLDcgKzE1MDIsOCBAQCBzdGF0aWMg c3RydWN0IGRybV9lbmNvZGVyICpkcm1fY29ubmVjdG9yX2dldF9lbmNvZGVyKHN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZQo+ICAJcmV0dXJuIGNvbm5lY3Rvci0+ZW5jb2RlcjsKPiAgfQo+ICAK PiAtc3RhdGljIGJvb2wgZHJtX21vZGVfZXhwb3NlX3RvX3VzZXJzcGFjZShjb25zdCBzdHJ1Y3Qg ZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiArc3RhdGljIGJvb2wgZHJtX21vZGVfZXhwb3NlX3Rv X3VzZXJzcGFjZShjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbGFzdF9tb2RlLAo+ICsJ CQkJCSBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSAqbW9kZSwKPiAgCQkJCQkgY29uc3Qg c3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYpCj4gIHsKPiAgCS8qCj4gQEAgLTE1MTEsNiArMTUx MiwxOCBAQCBzdGF0aWMgYm9vbCBkcm1fbW9kZV9leHBvc2VfdG9fdXNlcnNwYWNlKGNvbnN0IHN0 cnVjdCBkcm1fZGlzcGxheV9tb2RlICptb2RlLAo+ICAJICovCj4gIAlpZiAoIWZpbGVfcHJpdi0+ c3RlcmVvX2FsbG93ZWQgJiYgZHJtX21vZGVfaXNfc3RlcmVvKG1vZGUpKQo+ICAJCXJldHVybiBm YWxzZTsKPiArCS8qCj4gKwkgKiBJZiB1c2VyLXNwYWNlIGhhc24ndCBjb25maWd1cmVkIHRoZSBk cml2ZXIgdG8gZXhwb3NlIHRoZSBtb2Rlcwo+ICsJICogd2l0aCBhc3BlY3QtcmF0aW8sIGRvbid0 IGV4cG9zZSB0aGVtLgo+ICsJICovCj4gKwlpZiAoIWZpbGVfcHJpdi0+YXNwZWN0X3JhdGlvX2Fs bG93ZWQgJiYKPiArCSAgICBtb2RlLT5waWN0dXJlX2FzcGVjdF9yYXRpbyAhPSBIRE1JX1BJQ1RV UkVfQVNQRUNUX05PTkUgJiYKPiArCSAgICBkcm1fbW9kZV9tYXRjaChtb2RlLCBsYXN0X21vZGUs Cj4gKwkJCSAgIERSTV9NT0RFX01BVENIX1RJTUlOR1MgfAo+ICsJCQkgICBEUk1fTU9ERV9NQVRD SF9DTE9DSyB8Cj4gKwkJCSAgIERSTV9NT0RFX01BVENIX0ZMQUdTIHwKPiArCQkJICAgRFJNX01P REVfTUFUQ0hfM0RfRkxBR1MpKQo+ICsJCXJldHVybiBmYWxzZTsKPiAgCj4gIAlyZXR1cm4gdHJ1 ZTsKPiAgfQo+IEBAIC0xNTIyLDYgKzE1MzUsNyBAQCBpbnQgZHJtX21vZGVfZ2V0Y29ubmVjdG9y KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlzdHJ1Y3QgZHJtX2Nvbm5l Y3RvciAqY29ubmVjdG9yOwo+ICAJc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyOwo+ICAJc3Ry dWN0IGRybV9kaXNwbGF5X21vZGUgKm1vZGU7Cj4gKwlzdHJ1Y3QgZHJtX2Rpc3BsYXlfbW9kZSBs YXN0X3ZhbGlkX21vZGU7CgpBIHBvaW50ZXIgc2hvdWxkIGJlIHN1ZmZpY2llbnQuCgo+ICAJaW50 IG1vZGVfY291bnQgPSAwOwo+ICAJaW50IGVuY29kZXJzX2NvdW50ID0gMDsKPiAgCWludCByZXQg PSAwOwo+IEBAIC0xNTc3LDkgKzE1OTEsMTIgQEAgaW50IGRybV9tb2RlX2dldGNvbm5lY3Rvcihz dHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB2b2lkICpkYXRhLAo+ICAJb3V0X3Jlc3AtPmNvbm5lY3Rp b24gPSBjb25uZWN0b3ItPnN0YXR1czsKPiAgCj4gIAkvKiBkZWxheWVkIHNvIHdlIGdldCBtb2Rl cyByZWdhcmRsZXNzIG9mIHByZS1maWxsX21vZGVzIHN0YXRlICovCj4gKwltZW1zZXQoJmxhc3Rf dmFsaWRfbW9kZSwgMCwgc2l6ZW9mKHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlKSk7Cj4gIAlsaXN0 X2Zvcl9lYWNoX2VudHJ5KG1vZGUsICZjb25uZWN0b3ItPm1vZGVzLCBoZWFkKQo+IC0JCWlmIChk cm1fbW9kZV9leHBvc2VfdG9fdXNlcnNwYWNlKG1vZGUsIGZpbGVfcHJpdikpCj4gKwkJaWYgKGRy bV9tb2RlX2V4cG9zZV90b191c2Vyc3BhY2UoJmxhc3RfdmFsaWRfbW9kZSwgbW9kZSwgZmlsZV9w cml2KSkgewo+ICAJCQltb2RlX2NvdW50Kys7Cj4gKwkJCWRybV9tb2RlX2NvcHkoJmxhc3RfdmFs aWRfbW9kZSwgbW9kZSk7Cj4gKwkJfQo+ICAKPiAgCS8qCj4gIAkgKiBUaGlzIGlvY3RsIGlzIGNh bGxlZCB0d2ljZSwgb25jZSB0byBkZXRlcm1pbmUgaG93IG11Y2ggc3BhY2UgaXMKPiBAQCAtMTU4 OCwxMCArMTYwNSwxNiBAQCBpbnQgZHJtX21vZGVfZ2V0Y29ubmVjdG9yKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYsIHZvaWQgKmRhdGEsCj4gIAlpZiAoKG91dF9yZXNwLT5jb3VudF9tb2RlcyA+PSBt b2RlX2NvdW50KSAmJiBtb2RlX2NvdW50KSB7Cj4gIAkJY29waWVkID0gMDsKPiAgCQltb2RlX3B0 ciA9IChzdHJ1Y3QgZHJtX21vZGVfbW9kZWluZm8gX191c2VyICopKHVuc2lnbmVkIGxvbmcpb3V0 X3Jlc3AtPm1vZGVzX3B0cjsKPiArCQltZW1zZXQoJmxhc3RfdmFsaWRfbW9kZSwgMCwgc2l6ZW9m KHN0cnVjdCBkcm1fZGlzcGxheV9tb2RlKSk7Cj4gIAkJbGlzdF9mb3JfZWFjaF9lbnRyeShtb2Rl LCAmY29ubmVjdG9yLT5tb2RlcywgaGVhZCkgewo+IC0JCQlpZiAoIWRybV9tb2RlX2V4cG9zZV90 b191c2Vyc3BhY2UobW9kZSwgZmlsZV9wcml2KSkKPiArCQkJaWYgKCFkcm1fbW9kZV9leHBvc2Vf dG9fdXNlcnNwYWNlKCZsYXN0X3ZhbGlkX21vZGUsCj4gKwkJCQkJCQkgIG1vZGUsCj4gKwkJCQkJ CQkgIGZpbGVfcHJpdikpCj4gIAkJCQljb250aW51ZTsKPiAtCj4gKwkJCWlmICghZmlsZV9wcml2 LT5hc3BlY3RfcmF0aW9fYWxsb3dlZCkKPiArCQkJCW1vZGUtPnBpY3R1cmVfYXNwZWN0X3JhdGlv ID0KPiArCQkJCQkJSERNSV9QSUNUVVJFX0FTUEVDVF9OT05FOwoKSGVyZSB5b3UncmUgY2xvYmJl cmluZyB0aGUgaW50ZXJuYWwgbW9kZSBzdHJ1Y3R1cmUuIFRoYXQncyBub3QKYWNjZXB0YWJsZS4K Cj4gKwkJCWRybV9tb2RlX2NvcHkoJmxhc3RfdmFsaWRfbW9kZSwgbW9kZSk7Cj4gIAkJCWRybV9t b2RlX2NvbnZlcnRfdG9fdW1vZGUoJnVfbW9kZSwgbW9kZSk7Cj4gIAkJCWlmIChjb3B5X3RvX3Vz ZXIobW9kZV9wdHIgKyBjb3BpZWQsCj4gIAkJCQkJICZ1X21vZGUsIHNpemVvZih1X21vZGUpKSkg ewo+IC0tIAo+IDIuNy40CgotLSAKVmlsbGUgU3lyasOkbMOkCkludGVsIE9UQwpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBs aXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVz a3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK