All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Vishal Verma <vishal.l.verma@intel.com>
Cc: linux-nvdimm@lists.01.org
Subject: Re: [ndctl PATCH] ndctl: fix the default BTT sector size for reconfig
Date: Mon, 29 Jan 2018 14:25:35 -0700	[thread overview]
Message-ID: <20180129212535.GA5343@linux.intel.com> (raw)
In-Reply-To: <20180129202236.9744-1-vishal.l.verma@intel.com>

On Mon, Jan 29, 2018 at 01:22:36PM -0700, Vishal Verma wrote:
> reconfig attempted to reuse the 'previous' value for sector-size when
> reconfiguring to a BTT mode or blk type namespace, but this may not
> always be valid (for example when coming from a memory mode namespace).
> Instead, when reconfiguring to BTT or blk, always default to 4096
> unless a sector size is explicitly provided.
> 
> Cc: Dan Williams <dan.j.williams@intel.com>
> Reported-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Tested-by: Dave Jiang <dave.jiang@intel.com>
> Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

Yep, this both allows the btt namespace creation to continue and, if the user
does actually specify a bogus sector size, i.e.: 

# ./ndctl/ndctl create-namespace -f -e namespace0.0 --mode=sector -l0
failed to reconfigure namespace: Invalid argument

It prevents us from leaving our namespace in a zombie state where it is still
there but doesn't show up in 'ndctl list'.

Tested-by: Ross Zwisler <ross.zwisler@linux.intel.com>
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm

      parent reply	other threads:[~2018-01-29 21:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-29 20:22 [ndctl PATCH] ndctl: fix the default BTT sector size for reconfig Vishal Verma
2018-01-29 20:46 ` Dan Williams
2018-01-29 21:25 ` Ross Zwisler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129212535.GA5343@linux.intel.com \
    --to=ross.zwisler@linux.intel.com \
    --cc=linux-nvdimm@lists.01.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.