All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] ejabberd: Bump to version 17.11
Date: Mon, 29 Jan 2018 22:29:37 +0100	[thread overview]
Message-ID: <20180129222937.31264d2d@windsurf.lan> (raw)
In-Reply-To: <20180119162931.27721-1-johan.oudinet@gmail.com>

Hello,

On Fri, 19 Jan 2018 17:29:31 +0100, Johan Oudinet wrote:
> * Adapt all patches.
> * Use the new configure option enable-system-deps even though there is
>   still a patch needed to correct includes.
> * Disable graphics to not depends on X libraries. Disable also
>   mod_avatar from the default loaded modules, since this module
>   requires graphics enabled.
> 
> Signed-off-by: Johan Oudinet <johan.oudinet@gmail.com>

Thanks for this new version, I've applied to master. However, I have
one question below.


> -EJABBERD_ERLANG_LIBS = sasl crypto public_key ssl mnesia inets compiler
> +# Install check-erlang-lib script to the directory in which the
> +# package has been uncompressed, so it is available during the
> +# configure step.
> +define EJABBERD_INSTALL_CHECK_ERLANG_LIB
> +	$(INSTALL) -m 0755 $(EJABBERD_PKGDIR)/check-erlang-lib \
> +		$(@D)/check-erlang-lib
> +endef
> +
> +EJABBERD_POST_EXTRACT_HOOKS += EJABBERD_INSTALL_CHECK_ERLANG_LIB
> +
> +EJABBERD_ERLANG_LIBS = sasl public_key mnesia inets compiler
>  
>  # Guess answers for these tests, configure will bail out otherwise
>  # saying error: cannot run test program while cross compiling.
>  EJABBERD_CONF_ENV = \
>  	ac_cv_erlang_root_dir="$(HOST_DIR)/lib/erlang" \
>  	$(foreach lib,$(EJABBERD_ERLANG_LIBS), \
> -		ac_cv_erlang_lib_dir_$(lib)="`package/ejabberd/check-erlang-lib $(lib)`")
> +		ac_cv_erlang_lib_dir_$(lib)="`./check-erlang-lib $(lib)`")

Why did you change the location of check-erlang-lib ? What was the
problem ? It looked like a good idea to directly used it from
package/ejabberd/ instead of copying it.

Could you explain this ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

  reply	other threads:[~2018-01-29 21:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-19 16:29 [Buildroot] [PATCH v2] ejabberd: Bump to version 17.11 Johan Oudinet
2018-01-29 21:29 ` Thomas Petazzoni [this message]
2018-02-08 16:30   ` Johan Oudinet
2018-02-08 17:39     ` Arnout Vandecappelle
2018-02-09 16:05       ` Johan Oudinet
2018-02-09 17:10         ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180129222937.31264d2d@windsurf.lan \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.