From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/edid: use false for boolean value Date: Tue, 30 Jan 2018 10:43:53 +0100 Message-ID: <20180130094353.GH25930@phenom.ffwll.local> References: <20180123164607.GA25071@embeddedgus> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id A8FC36E71D for ; Tue, 30 Jan 2018 09:43:57 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id 143so19691868wma.5 for ; Tue, 30 Jan 2018 01:43:57 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180123164607.GA25071@embeddedgus> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Gustavo A. R. Silva" Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, "Gustavo A. R. Silva" , Daniel Vetter List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKYW4gMjMsIDIwMTggYXQgMTA6NDY6MDdBTSAtMDYwMCwgR3VzdGF2byBBLiBSLiBT aWx2YSB3cm90ZToKPiBBc3NpZ24gdHJ1ZSBvciBmYWxzZSB0byBib29sZWFuIHZhcmlhYmxlcyBp bnN0ZWFkIG9mIGFuIGludGVnZXIgdmFsdWUuCj4gCj4gVGhpcyBpc3N1ZSB3YXMgZGV0ZWN0ZWQg d2l0aCB0aGUgaGVscCBvZiBDb2NjaW5lbGxlLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEd1c3Rhdm8g QS4gUi4gU2lsdmEgPGd1c3Rhdm9AZW1iZWRkZWRvci5jb20+CgpUaGFua3MgZm9yIHlvdXIgcGF0 Y2guCgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vZHJtX2VkaWQuYyB8IDIgKy0KPiAgMSBmaWxl IGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fZWRpZC5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMK PiBpbmRleCBkZGQ1Mzc5Li40NWE4MGQ3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fZWRpZC5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9lZGlkLmMKPiBAQCAtMjc2Nyw3 ICsyNzY3LDcgQEAgZG9fZGV0YWlsZWRfbW9kZShzdHJ1Y3QgZGV0YWlsZWRfdGltaW5nICp0aW1p bmcsIHZvaWQgKmMpCj4gIAo+ICAJCWRybV9tb2RlX3Byb2JlZF9hZGQoY2xvc3VyZS0+Y29ubmVj dG9yLCBuZXdtb2RlKTsKPiAgCQljbG9zdXJlLT5tb2RlcysrOwo+IC0JCWNsb3N1cmUtPnByZWZl cnJlZCA9IDA7Cj4gKwkJY2xvc3VyZS0+cHJlZmVycmVkID0gZmFsc2U7CgpUaGVyZSdzIGFsc28K CgkJLnByZWZlcnJlZCA9IDEsCgppbiBhZGRfZGV0YWlsZWRfbW9kZXMuIFBsZWFzZSBmaXggdGhh dCBvbmUgdXAgdG9vIGZvciBjb25zaXN0ZW5jeSwgdGhlbgpJJ2xsIG1lcmdlIHlvdXIgcGF0Y2gu CgpDaGVlcnMsIERhbmllbAoKPiAgCX0KPiAgfQo+ICAKPiAtLSAKPiAyLjcuNAo+IAo+IF9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gZHJpLWRldmVsIG1h aWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAoKLS0gCkRhbmll bCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9n LmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f CmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751541AbeA3JoA (ORCPT ); Tue, 30 Jan 2018 04:44:00 -0500 Received: from mail-wm0-f66.google.com ([74.125.82.66]:50710 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751249AbeA3Jn5 (ORCPT ); Tue, 30 Jan 2018 04:43:57 -0500 X-Google-Smtp-Source: AH8x227eEJhV0kUxr4/QM+yTxlLPaCDDFwJCYucdZbTXkfAHJnEGWzB8fAYqH8XSrQTzbCth8T0QCQ== Date: Tue, 30 Jan 2018 10:43:53 +0100 From: Daniel Vetter To: "Gustavo A. R. Silva" Cc: Daniel Vetter , Gustavo Padovan , Sean Paul , David Airlie , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/edid: use false for boolean value Message-ID: <20180130094353.GH25930@phenom.ffwll.local> Mail-Followup-To: "Gustavo A. R. Silva" , Daniel Vetter , Gustavo Padovan , Sean Paul , David Airlie , "Gustavo A. R. Silva" , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20180123164607.GA25071@embeddedgus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180123164607.GA25071@embeddedgus> X-Operating-System: Linux phenom 4.14.0-1-amd64 User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 23, 2018 at 10:46:07AM -0600, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Thanks for your patch. > --- > drivers/gpu/drm/drm_edid.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c > index ddd5379..45a80d7 100644 > --- a/drivers/gpu/drm/drm_edid.c > +++ b/drivers/gpu/drm/drm_edid.c > @@ -2767,7 +2767,7 @@ do_detailed_mode(struct detailed_timing *timing, void *c) > > drm_mode_probed_add(closure->connector, newmode); > closure->modes++; > - closure->preferred = 0; > + closure->preferred = false; There's also .preferred = 1, in add_detailed_modes. Please fix that one up too for consistency, then I'll merge your patch. Cheers, Daniel > } > } > > -- > 2.7.4 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch