From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH] sound/tlv320dac33: Add device tree support Date: Tue, 30 Jan 2018 11:00:23 +0100 Message-ID: <20180130100023.GB18104@amd> References: <20180129230539.GA18280@amd> <20180129232031.GA7695@lenoch> <20180129233301.GA18104@amd> <20180130083446.GA13498@lenoch> <20180130085314.GA4585@amd> <1141b126-b883-a246-85ad-c5a69acb90bb@gmail.com> <20180130093838.GA15195@lenoch> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Return-path: Content-Disposition: inline In-Reply-To: <20180130093838.GA15195@lenoch> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ladislav Michl Cc: Filip =?utf-8?Q?Matijevi=C4=87?= , lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, perex-/Fr2/VpizcU@public.gmane.org, tiwai-IBi9RG/b67k@public.gmane.org, bhumirks-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, pali.rohar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, sre-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel , linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, aaro.koskinen-X3B1VOXEql0@public.gmane.org, ivo.g.dimitrov.75-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, patrikbachan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org, abcloriens-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, clayton-fehKsxFhGzZIf6P1QZMOBw@public.gmane.org, martijn-28JJ9oSIdodmR6Xm/wNWPw@public.gmane.org, sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org List-Id: alsa-devel@alsa-project.org --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2018-01-30 10:38:38, Ladislav Michl wrote: > On Tue, Jan 30, 2018 at 10:11:02AM +0100, Filip Matijevi=C4=87 wrote: > > Hi, > >=20 > > > Well, notice I'm converting existing driver to device tree. And that > > > one already has GPIO dependency. It is possible that more work needs > > > to be done there, but that should not be a reason to delay this. Feel > > > free to help. >=20 > Adding DT properties that need to be maintained for compatibility reasons > is a bad idea and very good reason to delay merging unfinished stuff. > And meanwhile it turned out it is not power-gpio :) I believe reset-gpios and power-gpios are commonly used like this... and that's what the old code does. You are not helping. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlpwQjcACgkQMOfwapXb+vKkTACgkNTAPlrFaYM1KRwWZe+QSlUZ EnwAoLP4x3zT5zTZ+/efNUlHJTeJzQVr =N3vk -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg-- -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: pavel@ucw.cz (Pavel Machek) Date: Tue, 30 Jan 2018 11:00:23 +0100 Subject: [PATCH] sound/tlv320dac33: Add device tree support In-Reply-To: <20180130093838.GA15195@lenoch> References: <20180129230539.GA18280@amd> <20180129232031.GA7695@lenoch> <20180129233301.GA18104@amd> <20180130083446.GA13498@lenoch> <20180130085314.GA4585@amd> <1141b126-b883-a246-85ad-c5a69acb90bb@gmail.com> <20180130093838.GA15195@lenoch> Message-ID: <20180130100023.GB18104@amd> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue 2018-01-30 10:38:38, Ladislav Michl wrote: > On Tue, Jan 30, 2018 at 10:11:02AM +0100, Filip Matijevi? wrote: > > Hi, > > > > > Well, notice I'm converting existing driver to device tree. And that > > > one already has GPIO dependency. It is possible that more work needs > > > to be done there, but that should not be a reason to delay this. Feel > > > free to help. > > Adding DT properties that need to be maintained for compatibility reasons > is a bad idea and very good reason to delay merging unfinished stuff. > And meanwhile it turned out it is not power-gpio :) I believe reset-gpios and power-gpios are commonly used like this... and that's what the old code does. You are not helping. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 181 bytes Desc: Digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752134AbeA3KA2 (ORCPT ); Tue, 30 Jan 2018 05:00:28 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:49686 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751391AbeA3KAZ (ORCPT ); Tue, 30 Jan 2018 05:00:25 -0500 Date: Tue, 30 Jan 2018 11:00:23 +0100 From: Pavel Machek To: Ladislav Michl Cc: Filip =?utf-8?Q?Matijevi=C4=87?= , lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com, perex@perex.cz, tiwai@suse.com, bhumirks@gmail.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, pali.rohar@gmail.com, sre@kernel.org, linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com, clayton@craftyguy.net, martijn@brixit.nl, sakari.ailus@linux.intel.com Subject: Re: [PATCH] sound/tlv320dac33: Add device tree support Message-ID: <20180130100023.GB18104@amd> References: <20180129230539.GA18280@amd> <20180129232031.GA7695@lenoch> <20180129233301.GA18104@amd> <20180130083446.GA13498@lenoch> <20180130085314.GA4585@amd> <1141b126-b883-a246-85ad-c5a69acb90bb@gmail.com> <20180130093838.GA15195@lenoch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="dTy3Mrz/UPE2dbVg" Content-Disposition: inline In-Reply-To: <20180130093838.GA15195@lenoch> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --dTy3Mrz/UPE2dbVg Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue 2018-01-30 10:38:38, Ladislav Michl wrote: > On Tue, Jan 30, 2018 at 10:11:02AM +0100, Filip Matijevi=C4=87 wrote: > > Hi, > >=20 > > > Well, notice I'm converting existing driver to device tree. And that > > > one already has GPIO dependency. It is possible that more work needs > > > to be done there, but that should not be a reason to delay this. Feel > > > free to help. >=20 > Adding DT properties that need to be maintained for compatibility reasons > is a bad idea and very good reason to delay merging unfinished stuff. > And meanwhile it turned out it is not power-gpio :) I believe reset-gpios and power-gpios are commonly used like this... and that's what the old code does. You are not helping. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --dTy3Mrz/UPE2dbVg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlpwQjcACgkQMOfwapXb+vKkTACgkNTAPlrFaYM1KRwWZe+QSlUZ EnwAoLP4x3zT5zTZ+/efNUlHJTeJzQVr =N3vk -----END PGP SIGNATURE----- --dTy3Mrz/UPE2dbVg--