All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tvrtko Ursulin <tursulin@ursulin.net>
To: igt-dev@lists.freedesktop.org
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: [igt-dev] [PATCH i-g-t 00/11] trace.pl fixes
Date: Tue, 30 Jan 2018 10:11:06 +0000	[thread overview]
Message-ID: <20180130101119.15758-1-tvrtko.ursulin@linux.intel.com> (raw)

From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

Collection of fixes on top of John's recent work.

Problems were mostly in the request split logic which had several issues both
in my original version, and also after John's improvements.

Handling of "incomplete" requests (the ones which received neither notify nor
context complete) was also a bit incorrect.

After this series it seems to work fine, famous last words. Anyway with my test
data it correctly draws the timeline with no overalaps considering both merged
requests and submission to port 1.

I also added context colouring mode so it is easier to follow the timeline and
started using hw_id for context id's for additional readability.

John Harrison (4):
  scripts/trace.pl: More hash key optimisations
  scripts/trace.pl: Sort order
  scripts/trace.pl: Calculate stats only after all munging
  scripts/trace.pl: Simplify 'end' & 'notify' generation

Tvrtko Ursulin (7):
  trace.pl: Use context hw_id as context id
  trace.pl: Move sortQueue near its user
  trace.pl: Move min/max timestamp lookup to last loop
  trace.pl: Fix engine busy accounting in split mode
  trace.pl: Add support for colouring context execution
  trace.pl: Fix incomplete request handling
  trace.pl: Fix request split mode

 scripts/trace.pl | 355 ++++++++++++++++++++++++++++++++++++++++---------------
 1 file changed, 259 insertions(+), 96 deletions(-)

-- 
2.14.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

             reply	other threads:[~2018-01-30 10:11 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-30 10:11 Tvrtko Ursulin [this message]
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 01/11] scripts/trace.pl: More hash key optimisations Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 02/11] scripts/trace.pl: Sort order Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 03/11] scripts/trace.pl: Calculate stats only after all munging Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 04/11] scripts/trace.pl: Simplify 'end' & 'notify' generation Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 05/11] trace.pl: Use context hw_id as context id Tvrtko Ursulin
2018-01-30 12:29   ` Lionel Landwerlin
2018-02-06 18:37     ` Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 06/11] trace.pl: Move sortQueue near its user Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 06/11] trace.pl: Move sortQueue near to the user Tvrtko Ursulin
2018-01-30 10:34   ` Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 07/11] trace.pl: Move min/max timestamp lookup to last loop Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 08/11] trace.pl: Fix engine busy accounting in split mode Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 08/11] trace.pl: Split " Tvrtko Ursulin
2018-01-30 10:34   ` Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 09/11] trace.pl: Add support for colouring context execution Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 10/11] trace.pl: Fix incomplete request handling Tvrtko Ursulin
2018-01-30 10:11 ` [igt-dev] [PATCH i-g-t 11/11] trace.pl: Fix request split mode Tvrtko Ursulin
2018-01-30 15:05 ` [igt-dev] ✓ Fi.CI.BAT: success for trace.pl fixes Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180130101119.15758-1-tvrtko.ursulin@linux.intel.com \
    --to=tursulin@ursulin.net \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=tvrtko.ursulin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.