From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] dma-fence: add comment for WARN_ON in dma_fence_release() Date: Tue, 30 Jan 2018 11:33:18 +0100 Message-ID: <20180130103318.GQ25930@phenom.ffwll.local> References: <20180129154002.3287-1-oded.gabbay@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id ACDF66E91E for ; Tue, 30 Jan 2018 10:33:22 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id x4so2965050wmc.0 for ; Tue, 30 Jan 2018 02:33:22 -0800 (PST) Content-Disposition: inline In-Reply-To: <20180129154002.3287-1-oded.gabbay@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Oded Gabbay Cc: maarten.lankhorst@canonical.com, daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gTW9uLCBKYW4gMjksIDIwMTggYXQgMDU6NDA6MDJQTSArMDIwMCwgT2RlZCBHYWJiYXkgd3Jv dGU6Cj4gSW4gZG1hX2ZlbmNlX3JlbGVhc2UoKSB0aGVyZSBpcyBhIFdBUk5fT04gd2hpY2ggY291 bGQgYmUgdHJpZ2dlcmVkIGJ5Cj4gc2V2ZXJhbCBjYXNlcyBvZiB3cm9uZyBkbWEtZmVuY2UgdXNh Z2UuIFRoaXMgcGF0Y2ggYWRkcyBhIGNvbW1lbnQgdG8KPiBleHBsYWluIHR3byB1c2UtY2FzZXMg dG8gaGVscCBkcml2ZXIgZGV2ZWxvcGVycyB0aGF0IHVzZSBkbWEtZmVuY2UKPiBhbmQgdHJpZ2dl ciB0aGF0IFdBUk5fT04gdG8gYmV0dGVyIHVuZGVyc3RhbmQgdGhlIHJlYXNvbnMgZm9yIGl0Lgo+ IAo+IFNpZ25lZC1vZmYtYnk6IE9kZWQgR2FiYmF5IDxvZGVkLmdhYmJheUBnbWFpbC5jb20+CgpO b3Qgc3VyZSBob3cgdXNlZnVsIHRoaXMgaXMsIHRyeWluZyB0byBkbyBhbnl0aGluZyB3aXRoIGEg ZG1hX2ZlbmNlIHdoaWxlCm5vdCBob2xkaW5nIGEgcmVmZXJlbmNlIGlzIGp1c3QgcGxhaW4gYnVn Z3kuIElmIHlvdSBkbyB0aGF0LCB0aGVuIGFsbApraW5kcyBvZiB1c2UtYWZ0ZXItZnJlZSBoaWxh cml0eSBjYW4gaGFwcGVuLiBUcnlpbmcgdG8gZW51bWVyYXRlIGFsbCB0aGUKd2F5cyB5b3UgY2Fu IGdldCByZWZjb3VudGluZyB3cm9uZyBzZWVtcyBmdXRpbGUuCgpXaGF0IHdlIG1heWJlIGNvdWxk IGRvIGlzIGEgc2ltcGxlIG9uZS1saW5lIGxpa2UKCgkvKiBGYWlsZWQgdG8gc2lnbmFsIGJlZm9y ZSByZWxlYXNlLCBjb3VsZCBiZSBhIHJlZmNvdW50aW5nIGlzc3VlLiAqLwoKSSB0aGluayB0aGlz IGlzIGdlbmVyYWxseSBhIHRydWUgc3RhdGVtZW50IGFuZCBtb3JlIHVzZWZ1bCBoaW50IGZvciB0 aGUKbmV4dCBjb252b2x1dGVkIHNjZW5hcmlvICh3aGljaCBpbiBhbGwgbGlrZWxpaG9vZCB3aWxs IGJlIGRpZmZlcmVudCBmcm9tCnlvdXJzKS4KLURhbmllbAoKPiAtLS0KPiAgZHJpdmVycy9kbWEt YnVmL2RtYS1mZW5jZS5jIHwgMzMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrCj4g IDEgZmlsZSBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZG1hLWJ1Zi9kbWEtZmVuY2UuYyBiL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtZmVuY2UuYwo+IGlu ZGV4IDVkMTAxYzQwNTNlMC4uYTcxNzBhYjIzZWMwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZG1h LWJ1Zi9kbWEtZmVuY2UuYwo+ICsrKyBiL2RyaXZlcnMvZG1hLWJ1Zi9kbWEtZmVuY2UuYwo+IEBA IC0xNzEsNiArMTcxLDM5IEBAIHZvaWQgZG1hX2ZlbmNlX3JlbGVhc2Uoc3RydWN0IGtyZWYgKmty ZWYpCj4gIAo+ICAJdHJhY2VfZG1hX2ZlbmNlX2Rlc3Ryb3koZmVuY2UpOwo+ICAKPiArCS8qCj4g KwkgKiBJZiB0aGUgV0FSTl9PTiBiZWxvdyBpcyB0cmlnZ2VyZWQgaXQgY291bGQgYmUgYmVjYXVz ZSB0aGUgZG1hIGZlbmNlCj4gKwkgKiB3YXMgbm90IHNpZ25hbGVkIGFuZCB0aGVyZWZvcmUsIHRo ZSBjYiBsaXN0IGlzIHN0aWxsIG5vdCBlbXB0eQo+ICsJICogYmVjYXVzZSB0aGUgY2IgZnVuY3Rp b25zIHdlcmUgbm90IGNhbGxlZC4KPiArCSAqCj4gKwkgKiBBIG1vcmUgc3VidGxlIGNhc2UgaXMg d2hlcmUgdGhlIGZlbmNlIGdvdCBzaWduYWxlZCBieSBhIHRocmVhZCB0aGF0Cj4gKwkgKiBkaWRu J3QgaG9sZCBhIHJlZiB0byB0aGUgZmVuY2UuIFRoZSBmb2xsb3dpbmcgZGVzY3JpYmVzIHRoZSBz Y2VuYXJpbzoKPiArCSAqCj4gKwkgKiAgICAgIFRocmVhZCBBICAgICAgICAgICAgICAgICAgICAg ICAgICAgIFRocmVhZCBCCj4gKwkgKi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tICAgICAgICAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICsJICogY2FsbHMgZG1hX2ZlbmNlX3NpZ25hbCgp IHsKPiArCSAqICAgICAgc2V0IHNpZ25hbCBiaXQKPiArCSAqCj4gKwkgKiAgICAgICAgICAgIHNj aGVkdWxlZCBvdXQKPiArCSAqICAgICAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tPiBjYWxs cyBkbWFfZmVuY2Vfd2FpdF90aW1lb3V0KCkgYW5kCj4gKwkgKiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcmV0dXJucyBpbW1lZGlhdGVseQo+ICsJICoKPiArCSAqICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBjYWxscyBkbWFfZmVuY2VfcHV0KCkKPiArCSAqICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8Cj4gKwkgKiAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfHRocmVhZCBBIGRvZXNuJ3QgaG9sZCByZWYK PiArCSAqICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8dG8gZmVuY2Ug c28gcmVmIGdvZXMgdG8gMAo+ICsJICogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHxhbmQgcmVsZWFzZSBpcyBjYWxsZWQKPiArCSAqICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICB8Cj4gKwkgKiAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgLT4gZG1hX2ZlbmNlX3JlbGVhc2UoKQo+ICsJICogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwKPiArCSAqICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAtPiBXQVJOX09OIHRyaWdnZXJlZAo+ICsJICoKPiArCSAq ICAgICAgZ28gb3ZlciBDQiBsaXN0LAo+ICsJICogICAgICBjYWxsIGVhY2ggQ0IgYW5kIHJlbW92 ZSBpdAo+ICsJICogICAgICB9Cj4gKwkgKgo+ICsJICoKPiArCSAqLwo+ICAJV0FSTl9PTighbGlz dF9lbXB0eSgmZmVuY2UtPmNiX2xpc3QpKTsKPiAgCj4gIAlpZiAoZmVuY2UtPm9wcy0+cmVsZWFz ZSkKPiAtLSAKPiAyLjE0LjMKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVy LCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK