From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Konstantin Ananyev <konstantin.ananyev@intel.com>, dev@dpdk.org
Subject: Re: [PATCH v3 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb()
Date: Tue, 30 Jan 2018 11:33:16 -0800 [thread overview]
Message-ID: <20180130113316.146088f5@xeon-e3> (raw)
In-Reply-To: <3552780.vzqTqTtnLr@xps>
On Mon, 29 Jan 2018 16:47:45 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:
> 15/01/2018 16:09, Konstantin Ananyev:
> > On x86 it is possible to use lock-prefixed instructions to get
> > the similar effect as mfence.
> > As pointed by Java guys, on most modern HW that gives a better
> > performance than using mfence:
> > https://shipilev.net/blog/2014/on-the-fence-with-dependencies/
> > That patch adopts that technique for rte_smp_mb() implementation.
> > On BDW 2.2 mb_autotest on single lcore reports 2X cycle reduction,
> > i.e. from ~110 to ~55 cycles per operation.
> >
> > Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>
> Applied, thanks
Does this change since lfence is one of the ways to block Spectre variant.
next prev parent reply other threads:[~2018-01-30 19:33 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 11:12 [PATCH 1/2] test/test: introduce new test-case for rte_smp_mb() Konstantin Ananyev
2017-12-01 11:12 ` [PATCH 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb() Konstantin Ananyev
2017-12-01 18:04 ` Stephen Hemminger
2017-12-01 23:08 ` Ananyev, Konstantin
2018-03-08 21:15 ` Stephen Hemminger
2017-12-11 17:11 ` Bruce Richardson
2017-12-11 17:30 ` Ananyev, Konstantin
2017-12-18 15:34 ` [PATCH v2 0/2] eal/x86: Optimize rte_smp_mb() and create a new test case for it Konstantin Ananyev
2017-12-18 15:34 ` [PATCH v2 1/2] test/test: introduce new test-case for rte_smp_mb() Konstantin Ananyev
2018-01-12 17:23 ` Thomas Monjalon
2018-01-12 17:58 ` Ananyev, Konstantin
2018-01-13 13:54 ` Wiles, Keith
2018-01-13 13:54 ` Wiles, Keith
2018-01-15 15:04 ` [PATCH v3 0/2] eal/x86: Optimize rte_smp_mb() and create a new test case for it Konstantin Ananyev
2018-01-15 15:04 ` [PATCH v3 1/2] test/test: introduce new test-case for rte_smp_mb() Konstantin Ananyev
2018-01-16 0:16 ` Thomas Monjalon
2018-01-15 15:04 ` [PATCH v3 2/2] eal/x86: Use lock-prefixed instructions to reduce cost of rte_smp_mb() Konstantin Ananyev
2018-01-15 15:09 ` Konstantin Ananyev
[not found] ` <8b05f533-d146-7f97-48f4-82ddcfc3613b@redhat.com>
2018-01-16 1:54 ` Fwd: " Michael S. Tsirkin
2018-01-29 9:29 ` Ananyev, Konstantin
2018-01-29 17:29 ` Michael S. Tsirkin
2018-01-29 15:47 ` Thomas Monjalon
2018-01-30 19:33 ` Stephen Hemminger [this message]
2017-12-18 15:34 ` [PATCH v2 " Konstantin Ananyev
2017-12-18 15:46 ` Bruce Richardson
2017-12-11 17:08 ` [PATCH 1/2] test/test: introduce new test-case for rte_smp_mb() Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180130113316.146088f5@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.